Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to login with validate code and be redirected to Workspace/Card modal #4519

Merged
merged 36 commits into from
Aug 20, 2021
Merged

Allow users to login with validate code and be redirected to Workspace/Card modal #4519

merged 36 commits into from
Aug 20, 2021

Commits on Aug 9, 2021

  1. Add new routes

    Amal Nazeem committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    c64aeff View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2021

  1. Add workspace_card route to be available when validating login and re… 

    …directing
    Amal Nazeem committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    d5b58c1 View commit details
    Browse the repository at this point in the history

  2. remove console statements and add missing import

    Amal Nazeem committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    38d8a24 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:Expensify/App into amal-validate-co… 

    …de-reuse
    Amal Nazeem committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    11145dd View commit details
    Browse the repository at this point in the history

  4. Update uses to remove VALIDATE_ since we aren't validating logins

    Amal Nazeem committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    ee2e220 View commit details
    Browse the repository at this point in the history

  5. Rename to redirectAfterSignIn so flag is generic to all validateCodeL… 

    …ogin routes
    Amal Nazeem committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    0bec935 View commit details
    Browse the repository at this point in the history

  6. Rename component and constants to match generic functionality of logg… 

    …ing with validate code
    Amal Nazeem committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    6d20074 View commit details
    Browse the repository at this point in the history

  7. Rename files to fit new generic functionality

    Amal Nazeem committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    7ca2bb3 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. Merge branch 'main' of github.com:Expensify/App into amal-validate-co… 

    …de-reuse
    Amal Nazeem committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    e395f45 View commit details
    Browse the repository at this point in the history

  2. Remove uneeded line

    Amal Nazeem committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    b4e635e View commit details
    Browse the repository at this point in the history

  3. Clearer comment

    Amal Nazeem committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    f47c728 View commit details
    Browse the repository at this point in the history

  4. Fix missing parentheses

    Amal Nazeem committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    1b0607b View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2021

  1. Merge branch 'main' of github.com:Expensify/App into amal-validate-co… 

    …de-reuse
    Amal Nazeem committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    1c330be View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:Expensify/App into amal-validate-co… 

    …de-reuse
    Amal Nazeem committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    5ca0808 View commit details
    Browse the repository at this point in the history

  3. Remove unused public workspace route

    Amal Nazeem committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    4b5c433 View commit details
    Browse the repository at this point in the history

  4. rename to setRedirectAfterSignIn

    Amal Nazeem committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    223c4be View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2021

  1. consolidated beta loading logic in LoginWith components

    Amal Nazeem committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    ed2a67e View commit details
    Browse the repository at this point in the history

  2. Make sure new policy is autocreated only after all policies have been… 

    … loaded
    Amal Nazeem committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    f0ffacf View commit details
    Browse the repository at this point in the history

  3. remove unused proptype

    Amal Nazeem committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    8115017 View commit details
    Browse the repository at this point in the history

  4. revert change to permissions

    Amal Nazeem committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    8cceef2 View commit details
    Browse the repository at this point in the history

  5. fix comment typo

    Amal Nazeem committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    d154f44 View commit details
    Browse the repository at this point in the history

  6. Show loader to prevent user from being immediately rerouted to the ho… 

    …me page
    Amal Nazeem committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    90b2c21 View commit details
    Browse the repository at this point in the history

  7. Fix 2fa page's styles

    Amal Nazeem committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    876fc46 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' of github.com:Expensify/App into amal-validate-co… 

    …de-reuse
    Amal Nazeem committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    cd50b67 View commit details
    Browse the repository at this point in the history

  9. Fix missing React import needed for FullScreenLoadingIndicator

    Amal Nazeem committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    ec60643 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2021

  1. Use existing collection to determine if policies have been loaded

    Amal Nazeem committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    501dd95 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2021

  1. Use switch and add comments for clarity

    Amal Nazeem committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    786b57e View commit details
    Browse the repository at this point in the history

  2. Use existing policies collection to determine if policies have loaded

    Amal Nazeem committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    96b4a4a View commit details
    Browse the repository at this point in the history

  3. Use screens relevant to validateCode not 2fa

    Amal Nazeem committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    cc0c2b8 View commit details
    Browse the repository at this point in the history

  4. Remove unused Onyx key

    Amal Nazeem committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    fac742e View commit details
    Browse the repository at this point in the history

  5. Clarify when this logic can be removed

    Amal Nazeem committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    fcbeadf View commit details
    Browse the repository at this point in the history

  6. Add todo to comment so it's clearer theres some action to be done in … 

    …remove this
    Amal Nazeem committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    b40cabf View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2021

  1. Add missing doc

    Amal Nazeem committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    20ee86a View commit details
    Browse the repository at this point in the history

  2. Use Policy to make code more contextual

    Amal Nazeem committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    23798c7 View commit details
    Browse the repository at this point in the history

  3. Use @

    Amal Nazeem committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    b4d779c View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2021

  1. remove @todo since workspace has already been created

    Amal Nazeem committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    3e6fae6 View commit details
    Browse the repository at this point in the history