Add /generated folder in android to .gitignore #4527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mountiny
changed the title
Julesssss
approved these changes
Aug 10, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Julesssss
Details
As per discussion in slack here, we have decided to add
android/app/src/main/java/com/expensify/chat/generated/to.gitignorefile as it gets created on Android app build but its content are not required to be committed. That causes problems for the developers who then manually have to remove that folder from the changes.Fixed Issues
No issue linked
Tests
No tests required. I have tested it locally and the gitignore file correctly omits the
/generatedfolder.QA Steps
Tested On
Screenshots
No screenshots needed.
Web
Mobile Web
Desktop
iOS
Android