Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[NoQA] E2E test. Linking, same page " #45302

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Revert "[NoQA] E2E test. Linking, same page " #45302

merged 1 commit into from
Jul 11, 2024

Conversation

Gonals
Copy link
Contributor

@Gonals Gonals commented Jul 11, 2024 •
edited
Loading

Reverts #44286

Fixes $ #45223

@Gonals Gonals self-assigned this Jul 11, 2024
@Gonals Gonals requested a review from a team as a code owner July 11, 2024 16:14
@Gonals Gonals mentioned this pull request Jul 11, 2024
Closed
50 tasks
@melvin-bot melvin-bot bot removed the request for review from a team July 11, 2024 16:14
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jul 11, 2024

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested a review from marcochavezf July 11, 2024 16:14
@Gonals Gonals merged commit 12a6f9a into main Jul 11, 2024
13 of 17 checks passed
@Gonals Gonals deleted the revert-44286-perunt/e2e-linking-same-page-test branch July 11, 2024 16:36
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jul 11, 2024

@Gonals looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Jul 11, 2024
@Gonals Gonals removed the Emergency label Jul 11, 2024
@Gonals
Copy link
Contributor Author

Gonals commented Jul 11, 2024

Just a revert. No need for checklists

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot mentioned this pull request Jul 15, 2024
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/Gonals in version: 9.0.7-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.0.7-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julesssss Julesssss Julesssss approved these changes

@iwiznia iwiznia iwiznia approved these changes

@marcochavezf marcochavezf Awaiting requested review from marcochavezf

Assignees

@Gonals Gonals

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gonals @OSBotify @iwiznia @Julesssss