Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow user to stay in room report screen #45370

Merged
merged 3 commits into from
Jul 16, 2024
Merged

fix: allow user to stay in room report screen #45370

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95b50cd
fix: allow user to say in room report screen
dominictb Jul 13, 2024
dc7b924
fix: update comments
dominictb Jul 15, 2024
6e10dc9
fix: update comments
dominictb Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/libs/actions/Report.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2704,6 +2704,12 @@ function leaveRoom(reportID: string, isWorkspaceMemberLeavingWorkspaceRoom = fal
};

API.write(WRITE_COMMANDS.LEAVE_ROOM, parameters, {optimisticData, successData, failureData});

// If this is the leave action from a workspace room or chat thread, simply dismiss the modal, i.e., allow the user to view the room/thread and join again immediately.
if (isWorkspaceMemberLeavingWorkspaceRoom || isChatThread) {
return;
}
// In other cases, the report is deleted and we should move the user to another report.
navigateToMostRecentReport(report);
}

Expand Down
Loading