-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily use reports collection for isArchived #45568
Conversation
@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Looking to get this merged as soon as possible and @hungvu193 responded here. Un-assigning @rayane-djouah and @mollfpr |
Also, I'm currently disabling lint each time for the private_isArchived variable. But we'll edit the eslint config in the future to allow for the 'private_' prefix and remove these disable lines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB, small changes needed
@@ -1286,12 +1286,9 @@ function isClosedExpenseReportWithNoExpenses(report: OnyxEntry<Report>): boolean | |||
/** | |||
* Whether the provided report is an archived room | |||
*/ | |||
// eslint-disable-next-line @typescript-eslint/no-unused-vars | |||
function isArchivedRoom(report: OnyxInputOrEntry<Report>, reportNameValuePairs?: OnyxInputOrEntry<ReportNameValuePairs>): boolean { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't need reportNameValuePairs
anymore, we should remove it as a param as well.
function isArchivedRoom(report: OnyxInputOrEntry<Report>, reportNameValuePairs?: OnyxInputOrEntry<ReportNameValuePairs>): boolean { | |
function isArchivedRoom(report: OnyxInputOrEntry<Report>): boolean { |
If so we should also update it in every place that we used this function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need it in the future because the 'private_isArchived' variable will be stores in reportNameValuePairs
instead of 'report'. This is just a temporary fix while we're sending the variable through 'report'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. I'll start testing now
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-07-18.at.12.45.01.movAndroid: mWeb ChromeScreen.Recording.2024-07-18.at.12.49.32.moviOS: NativeScreen.Recording.2024-07-18.at.12.41.26.moviOS: mWeb SafariScreen.Recording.2024-07-18.at.12.36.16.movMacOS: Chrome / Safarichrome1.movchrome2.movMacOS: Desktopdesktop.mp4 |
Also @hungvu193, not sure if you're already doing this but you can use something like the the below to get the private_isArchived rNVP loaded in Onyx since I don't believe the backend is returning that yet on production.
|
Thank you. 🙏 I was about to ask about it |
@srikarparsi I completed the checklist, let me know when the above PRs are deployed so I can retest |
@Beamanator Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Awesome thanks! Do you think you could add screenshots for the missing platforms as well if you have a chance just to make sure everything’s working? We might not have time to do a full retest between the time the above PRs are deployed and the time of the app deploy. |
Yeah, I'm completing the rest of them. One question, how do you add Onyx data for native platform like Android or IOS? |
Hmm I’m not sure actually. Do you think you could check in #expensify-open-source? Someone there might have an answer. If it’s not possible, then we can just test those once the PRs are deployed to production |
Yeah Cool, right now I'm testing offline case and it worked as expected so I added videos for Android and IOS as well. |
Just tested with the production backend and it seems to be working The one thing is that duplicate admins, announce and workspace chats are being created when a workspace is created. I don't think this is related to these changes because it's also happening on main. It was also happening yesterday here but it's not happening on today's staging build. |
🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.0.10-2 🚀
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.10-3 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/mountiny in version: 9.0.10-7 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.0.11-5 🚀
|
Details
Fixed Issues
$ #45658
PROPOSAL:
Tests
Ensure that you're able to chat on CLOSED reports
Ensure that archived chats still show up as archived
Offline tests
Be online
Go offline
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop