-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upload native logs #45905
feat: upload native logs #45905
Conversation
72bb25a
to
0f7cd8d
Compare
@kirillzyusko I'm trying to test locally, but I'm seeing this error when I run your branch on web:
Do we need to only import this module on native? |
@arosiclair let me check it! |
0f7cd8d
to
38657a4
Compare
@arosiclair I fixed build issues/compatibility with RN 0.73 - would you mind to check again? Now both native iOS and web should work without ant problems! |
I am still seeing the same errors. Unit tests are also failing for the same reason:
|
@arosiclair can you show the content of |
|
@arosiclair it's an old code 😔 Can you try to download latest version of the code? |
Same error even with the commit hash. Unit tests are broken for the same reason as well. There's something wrong with the way we added this package. Can you try reproducing the issue so you can investigate? The problem isn't fixed until unit tests start passing. I see the version in your repo has not changed from |
@arosiclair I pushed new changes - now everything should be working. Unit-tests are not failing anymore, I changed version to 0.2.0, so everything should be working now! |
Thanks web is working now. One more thing to fix: the notification service is not added to the app group on this branch. I updated it locally and the logs started showing in JS. Can you merge the latest from main? The app groups should already be set correctly there. |
c175c25
to
1614e6b
Compare
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Code LGTM, but push notifications are not working in my dev environment for some reason now so I can't do a final test. I reached out to Airship about it. Hopefully we hear back about it or maybe it'll just start working next week. |
Okay, waiting 👀 |
Reviewer Checklist
Screenshots/Videos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright this is working well! However there's one issue here:
Where the reportActionID
gets logged as <private>
. We should be able to fix that by updating the log format strings. We just need to update these two
- https://github.com/margelo/expensify-app-fork/blob/e0b8098e87a7455063ba8614c6fa6204e7f25747/ios/NotificationServiceExtension/NotificationService.swift#L51
- https://github.com/margelo/expensify-app-fork/blob/e0b8098e87a7455063ba8614c6fa6204e7f25747/ios/NotificationServiceExtension/NotificationService.swift#L221
and replace %@
with %{public}@
a78b8bc
to
9dfdb39
Compare
@arosiclair thanks! I applied all requested changes - would you mind to check again? 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes 👍
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/arosiclair in version: 9.0.43-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/arosiclair in version: 9.0.43-0 🚀
|
Internal QA ✅ It's working! |
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.43-6 🚀
|
Details
Added newly crafted
react-native-app-logs
library to intercept logs fromNotificationService
and re-use rich JS logging ecosystem (to send logs to server for further debugging).Fixed Issues
$ #42659
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop