Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for value before checking length #4613

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

stitesExpensify
Copy link
Contributor

Details

Regression due to this refactor. We just need to check if the value exists before we try to check the length.

Fixed Issues

$ #4599

Tests

  1. Enter the email for a new account on newDot
  2. Go to localhost:8080/setpassword//12345
  3. Make sure you don't get a white screen

QA Steps

  1. Input an email address for new account
  2. Check the inbox, long tap the link in the email. Tap "Copy" button.
  3. Paste the link into any app that renders hyperlinks as clickable objects.
  4. Add staging to the URL, so it says staging.new.expenisify.com....
  5. Tap the link.
  6. If the "Choose app to open with" modal appears, select "Expensify"
  7. Make sure you don't get a white screen or error

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

@stitesExpensify stitesExpensify self-assigned this Aug 12, 2021
@stitesExpensify stitesExpensify requested a review from a team August 12, 2021 18:32
@MelvinBot MelvinBot requested review from MariaHCD and removed request for a team August 12, 2021 18:33
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@francoisl francoisl merged commit 89f0630 into main Aug 12, 2021
@francoisl francoisl deleted the stites-preventUndefinedErrorInText branch August 12, 2021 19:19
github-actions bot pushed a commit that referenced this pull request Aug 12, 2021
…nText

Check for value before checking length

(cherry picked from commit 89f0630)
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @francoisl in version: 1.0.85-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @isagoico in version: 1.0.85-9 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @francoisl in version: 1.0.85-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants