-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offline and errors pattern in Quickbooks Online integration #46511
Merged
deetergp
merged 33 commits into
Expensify:main
from
software-mansion-labs:@zfurtak/qbo-error-messages
Sep 5, 2024
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
263743b
Initial refactor of import pages
zfurtak 362d521
Merge branch 'main' into @zfurtak/qbo-error-messages
zfurtak ab278cb
Adjusted import pages and refactored advanced page
zfurtak 2f73caa
Further refactor
zfurtak a98872e
Export pages refactor
zfurtak cabe722
Merge branch 'main' into @zfurtak/qbo-error-messages
zfurtak 4a2c570
Add error/offline patterns and refactor advanced pages
zfurtak 5de6c69
Adding missing patterns
zfurtak ee86a23
Merge branch 'main' into @zfurtak/qbo-error-messages
zfurtak 93c42d1
Revert max_request_retry value
zfurtak def4201
Adjustments
zfurtak 0cff3d9
Adjustments
zfurtak c109a1d
Adjusted to review
zfurtak e609478
Added needed conditions
zfurtak 0b181b3
Merge branch 'main' into @zfurtak/qbo-error-messages
zfurtak 26a9448
Adjust error patterns
zfurtak a5e667a
Fix console errors
zfurtak 0ca45ed
Adjusted to review
zfurtak 1600fe6
Style fix
zfurtak f95c601
Merge branch 'main' into @zfurtak/qbo-error-messages
zfurtak 21d34d0
Rerun the checks
zfurtak 893c8b1
Added missing setting
zfurtak a765f9b
Adjust code to react compiler
zfurtak 12c81e2
Merge branch 'main' into @zfurtak/qbo-error-messages
zfurtak 3c54077
Fix react compiler errors
zfurtak ce308ed
Remove opacity from empty list
zfurtak ee8a820
Merge branch 'main' into @zfurtak/qbo-error-messages
zfurtak 650192a
Remove opacity from empty list
zfurtak 1449d8a
Merge branch 'main' into @zfurtak/qbo-error-messages
zfurtak e5faeb4
Merge branch 'main' into @zfurtak/qbo-error-messages
zfurtak 9664819
Merge main
zfurtak 14875d2
Merge main
zfurtak 5e556ff
Added generic types for oldSettingValue
zfurtak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we make this value optional with
?
? I think it is not optional and it looks like we are passing it in every callThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because we pass values from QuickbooksOnline config that can be undefined
e.g. here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh, I see, thanks!