Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add autofocus & hoverstyle #4662

Merged
merged 1 commit into from
Aug 17, 2021
Merged

add autofocus & hoverstyle #4662

merged 1 commit into from
Aug 17, 2021

Conversation

thesahindia
Copy link
Member

@thesahindia thesahindia commented Aug 14, 2021

Details

As explained here #4498
We should highlight the option when User hover over it
and Input should be auto selected when the dialog opens

Fixed Issues

$ #4498

QA Steps

  1. Go to the app
  2. Use Request Money feature
  3. Select Currency
  4. Input will autoFocus and highlighting will be visible on hovering

Tested On

Couldn't test on Desktop & IOS as I don't have access to these platforms.

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

simplescreenrecorder-2021-08-14_16.32.49.mp4

Mobile Web

Screenrecorder-2021-08-14-17-22-41-64.mp4

Desktop

iOS

Android

Screenrecorder-2021-08-14-17-19-18-937.mp4

@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@thesahindia
Copy link
Member Author

I have read the CLA Document and I hereby sign the CLA

@thesahindia thesahindia marked this pull request as ready for review August 14, 2021 11:57
@thesahindia thesahindia requested a review from a team as a code owner August 14, 2021 11:57
@MelvinBot MelvinBot requested review from thienlnam and removed request for a team August 14, 2021 11:57
@thienlnam thienlnam merged commit d386f42 into Expensify:main Aug 17, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @thienlnam in version: 1.0.85-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Aug 25, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-01. 🎊

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Aug 30, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-06. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants