Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search label removed, added no results found instead #4689

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Search label removed, added no results found instead #4689

merged 1 commit into from
Aug 20, 2021

Conversation

Santhosh-Sellavel
Copy link
Collaborator

@Santhosh-Sellavel Santhosh-Sellavel commented Aug 17, 2021 •
edited
Loading

@Beamanator

Details

Just removed the search value and replaced it with No Results Found Message

Fixed Issues

$ #4163

Tests & QA Steps

  1. Click Search in From chat list
  2. Enter random search text ex: "724fg32ydtf"
  3. Click FAB + Icon -> New chat
  4. Search will appear Repeat Step 2
  5. Click FAB + Icon -> New Group
  6. Search will appear Repeat Step 2

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2021-08-17 at 5 31 05 PM

Screenshot 2021-08-17 at 5 30 18 PM

Screenshot 2021-08-17 at 5 29 43 PM

Mobile Web

Simulator.Screen.Recording.-.iPhone.11.-.2021-08-17.at.17.49.51.mp4

Desktop

Screenshot 2021-08-17 at 6 19 27 PM

Screenshot 2021-08-17 at 6 19 59 PM

Screenshot 2021-08-17 at 6 52 46 PM

iOS

Simulator.Screen.Recording.-.iPhone.12.-.2021-08-17.at.19.05.45.mov

Android

Screenshot_1629210669
Screenshot_1629210639
Screenshot_1629210655

@Santhosh-Sellavel Santhosh-Sellavel marked this pull request as ready for review August 17, 2021 13:49
@Santhosh-Sellavel Santhosh-Sellavel requested a review from a team as a code owner August 17, 2021 13:49
@MelvinBot MelvinBot requested review from puneetlath and removed request for a team August 17, 2021 13:49
@Santhosh-Sellavel
Copy link
Collaborator Author

Updated screenshots for android too!

@Beamanator Beamanator self-requested a review August 17, 2021 14:55
Beamanator
Beamanator approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I'll leave it for Puneet to review too

@Beamanator Beamanator merged commit 0f446f0 into Expensify:main Aug 20, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

This was referenced Aug 20, 2021
Closed
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Sep 1, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-08. 🎊

@Santhosh-Sellavel Santhosh-Sellavel deleted the Search_NoResults_Fix branch September 3, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Beamanator Beamanator Beamanator approved these changes

@puneetlath puneetlath Awaiting requested review from puneetlath

Assignees

@Santhosh-Sellavel Santhosh-Sellavel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Santhosh-Sellavel @OSBotify @botify @Beamanator