Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily returns "https://" as the default website #47314

Closed
wants to merge 4 commits into from
Closed

Temporarily returns "https://" as the default website #47314

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79adc54
temporarily always returns https://
bernhardoj Aug 13, 2024
da5df72
lint
bernhardoj Aug 13, 2024
ba25ad5
lint and ts
bernhardoj Aug 13, 2024
2a9ad80
Merge branch 'main' into fix/47227-temporarily-remove-generate-defaul…
bernhardoj Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/libs/BankAccountUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
import {Str} from 'expensify-common';
// import {Str} from 'expensify-common';
import type {OnyxEntry} from 'react-native-onyx';
import type * as OnyxTypes from '@src/types/onyx';

// eslint-disable-next-line @typescript-eslint/no-unused-vars
function getDefaultCompanyWebsite(session: OnyxEntry<OnyxTypes.Session>, user: OnyxEntry<OnyxTypes.User>): string {
return user?.isFromPublicDomain ? 'https://' : `https://www.${Str.extractEmailDomain(session?.email ?? '')}`;
// return user?.isFromPublicDomain ? 'https://' : `https://www.${Str.extractEmailDomain(session?.email ?? '')}`;
// temporarily always returns https:// to fix https://github.com/Expensify/App/issues/47227 until https://github.com/Expensify/App/issues/45278 is resolved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB: Instead of make a block code comment, we can create a constant with description

Suggested change
// return user?.isFromPublicDomain ? 'https://' : `https://www.${Str.extractEmailDomain(session?.email ?? '')}`;
// temporarily always returns https:// to fix https://github.com/Expensify/App/issues/47227 until https://github.com/Expensify/App/issues/45278 is resolved.
const isPending = true;
if (isPending) {
return 'https://';
}

return 'https://';
}

function getLastFourDigits(bankAccountNumber: string): string {
Expand Down
Loading