Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the /bank-account/requestor page #4742

Merged
merged 2 commits into from
Aug 18, 2021
Merged

Conversation

joelbettner
Copy link
Contributor

@Expensify/pullerbear will you please review?

Details

This PR allows the /bank-account/requestor page to display

Fixed Issues

$ #4728

Tests/QA

  1. Open the app
  2. Confirm you can load the new.expensify.com/bank-account/requestor page

@joelbettner joelbettner requested a review from a team August 18, 2021 18:28
@joelbettner joelbettner self-assigned this Aug 18, 2021
@MelvinBot MelvinBot requested review from Luke9389 and removed request for a team August 18, 2021 18:28
@joelbettner joelbettner changed the title import Text Display the /bank-account/requestor page Aug 18, 2021
@joelbettner joelbettner requested a review from a team as a code owner August 18, 2021 18:35
@MelvinBot MelvinBot requested review from tylerkaraszewski and removed request for a team August 18, 2021 18:36
@tylerkaraszewski
Copy link
Contributor

How do I get to "bank-account/requestor" within the app?

@joelbettner
Copy link
Contributor Author

@tylerkaraszewski I'm not sure about how to navigate there within the app. I just logged in and then entered the URL (new.expensify.com/bank-account/requestor). If you open your js console when you do that, you'll want to make sure you don't get the following:
image

Also, is it weird that pullerbear assigned two people?

@tylerkaraszewski
Copy link
Contributor

Screen Shot 2021-08-18 at 1 02 31 PM

Seems to work.

@Luke9389 Luke9389 merged commit d0d16ee into main Aug 18, 2021
@Luke9389 Luke9389 deleted the joel_displayRequestor branch August 18, 2021 22:01
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions bot pushed a commit that referenced this pull request Aug 25, 2021
Display the /bank-account/requestor page

(cherry picked from commit d0d16ee)
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @roryabraham in version: 1.0.86-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants