Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OldDot Rules Migration] Expense report rules #47468
[OldDot Rules Migration] Expense report rules #47468
Changes from 42 commits
3081420
3623d4a
3e622bf
e99bf88
bff54c3
94a0db2
b07708a
2e82822
0d6aa6f
4d15101
66382f0
6be513d
2169b17
132ccbb
285cf5e
5797fb1
2e75abd
45b46b4
72c38a4
6f59541
daa7c9c
b188339
36160d3
7e72524
21549c6
8c8f270
269dedd
34a5c4b
9bc374a
b881703
215a252
b1df169
b5c7486
0edff08
edc14fe
67e9e83
b89de0a
00b8175
05f9529
34eb99a
2af9b37
d23fb35
1f327fa
7b73789
db3f8c7
4b044a0
1ef024a
ea72e31
6d06f5d
7b8a235
058773f
6bcb2e4
9fc1685
79c5ae6
c48575b
a22d5fb
db46fb0
b9eb9ae
721a0ec
b229a26
816deeb
001041f
927461f
8a46e91
6cd2540
ed21e12
550939e
5d81f1b
1a008ba
e7fdedf
e921c73
3f0b321
ab1a8cb
020b1e3
c71279f
efe9fe6
2d55ee0
0ef8fb2
3f55bd3
442d734
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BrtqKr Please help to explain why we need to change this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I might have been missing something from the textinput version, but I might have fixed it while doing other things. It's probably no longer necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this, on the other hand, was necessary, because the error handling was broken in general
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please help to explain this change. Note that, this component is used in many places in our app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to use titleComponent to achieve a different styling and realized that it is not working with the variant I was planning to use. I'll remove it to avoid regressions from this PR and push it separately.