Fix GBR and error briefly show after connecting to QBO, Xero. #47483

hungvu193 · 2024-08-15T07:23:23Z

Details

While connecting to QBO or Xero, we will see an error message briefly at the end of the process, this PR will fix it.

Fixed Issues

$ #44148

#47855
PROPOSAL: N/A

Tests

Create a new workspace and enable Accounting feature.
Go to Accounting, click the Connect button right next to QBO (or Xero).
Verify there's no error shown briefly.
From QBO (or Xero dashboard), try to disconnect the Expensify App.
Go back to the app, and try to sync a few times, until you see Enter credentials options, click on that.
Enter correct credentials and go back to the Expensify app.
Verify that RBR shouldn't appear while syncing.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-08-20.at.09.36.21.mov

Android: mWeb Chrome

Screen.Recording.2024-08-20.at.09.27.42.mov

iOS: Native

Screen.Recording.2024-08-20.at.09.32.33.mov

iOS: mWeb Safari

Screen.Recording.2024-08-20.at.09.18.00.mov

MacOS: Chrome / Safari

Screen.Recording.2024-08-19.at.22.14.31.mov

MacOS: Desktop

Screen.Recording.2024-08-19.at.22.32.17.mov

hungvu193 · 2024-08-15T09:35:31Z

Hold for #44148 (comment)

src/libs/WorkspacesSettingsUtils.ts

melvin-bot · 2024-08-19T16:18:15Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2024-08-19T16:18:35Z

This should be ready for your review @war-in and @arosiclair . I'll complete the rest of the screenshots/videos tomorrow morning.

arosiclair

LGTM so far

hungvu193 · 2024-08-20T02:37:26Z

Completed the screenshots/videos.

getusha · 2024-08-20T07:21:54Z

@hungvu193 @arosiclair should i review this or it's handled as part of a project with someone else?

war-in

LGTM, only one question

src/pages/workspace/accounting/PolicyAccountingPage.tsx

hungvu193 · 2024-08-20T10:56:05Z

@hungvu193 @arosiclair should i review this or it's handled as part of a project with someone else?

Please hold your review. I think this PR is a follow-up of our current issue that we're working on 😄

arosiclair · 2024-08-20T14:11:22Z

@hungvu193 @arosiclair should i review this or it's handled as part of a project with someone else?

Please hold your review. I think this PR is a follow-up of our current issue that we're working on 😄

Nope this shouldn't be held on anything. We need to fix #44148. Please fix the new conflicts and then review @hungvu193 @getusha.

getusha · 2024-08-25T09:19:09Z

We don't want to display error message even if there's errorMessage unless connection?.lastSync?.isSuccessful is false, that's why 😄

I am not suggesting that. the condition is returning early if you look closely.

hungvu193 · 2024-08-25T11:03:51Z

I am not suggesting that. the condition is returning early if you look closely.

I mean, checking !connection?.lastSync?.errorMessage is not necessary, the only case we want to display errorMessage is when connection?.lastSync?.isSuccessful is false.

Nevermind, can you please use staging env to test Xero connection again? I've just checked and it seems working fine.

getusha · 2024-08-25T11:27:27Z

Nevermind, can you please use staging env to test Xero connection again? I've just checked and it seems working fine.

Of course it will appear to work since we are not showing an error when the last sync isn't a success based on your recent change.

https://github.com/Expensify/App/pull/47483/files#diff-1b4d0097f39f938389f788ddb79e471094a86831de5e33967693d9a3705b9ebeR387

if (isSyncInProgress || isEmptyObject(connection?.lastSync) || connection?.lastSync?.isSuccessful === false) {

I mean, checking !connection?.lastSync?.errorMessage is not necessary, the only case we want to display errorMessage is when connection?.lastSync?.isSuccessful is false.

Why do we want to show an empty error message?

hungvu193 · 2024-08-25T11:43:24Z

Why do we want to show an empty error message?

If connection?.lastSync?.isSuccessful isn't false, there won't be errorMessage, if connection?.lastSync?.errorMessage still have truly value, that will be BE issue, we also checked falsely value for errorMessage here so it won't be a problem:

App/src/pages/workspace/accounting/PolicyAccountingPage.tsx

Lines 74 to 79 in 0c84552

    
           const synchronizationError = connectedIntegration && getSynchronizationErrorMessage(policy, connectedIntegration, isSyncInProgress); 
        
           // Enter credentials item shouldn't be shown for SageIntacct and NetSuite integrations 
        
           const shouldShowEnterCredentials = 
        
               connectedIntegration && 
        
               !!synchronizationError &&

Of course it will appear to work since we are not showing an error when the last sync isn't a success based on your recent change.

Damn, that's bad merge, I'll update it shortly

hungvu193 · 2024-08-25T11:55:05Z

As I checked the logs, connection?.lastSync?.isSuccessful return false, then return true that's why we saw the error briefly.
Any thoughts? @arosiclair

arosiclair · 2024-08-26T12:19:11Z

As I checked the logs, connection?.lastSync?.isSuccessful return false, then return true that's why we saw the error briefly. Any thoughts? @arosiclair

What steps did you take to reproduce and with what integration?

hungvu193 · 2024-08-26T14:13:21Z

As I checked the logs, connection?.lastSync?.isSuccessful return false, then return true that's why we saw the error briefly. Any thoughts? @arosiclair

What steps did you take to reproduce and with what integration?

Here is the steps:
Precondition: use Staging env

Disconnect Xero if you're connected
Connect with Xero
Log the value of connection inside "getSynchronizationErrorMessage" function.

hungvu193 · 2024-08-26T14:49:44Z

I can also reproduce this on Staging.
There're 2 Pusher events were pushed almost at the same time, one event sent isSuccessful: false, the other one sent isSuccessful: true.

[info] [Report] Handled multipleEvents event sent by Pusher - {"updates":[{"data":[{"key":"policy_57692AA062EC69B3","onyxMethod":"merge","value":{"connections":{"xero":{"config":{"enableNewCategories":true}}}}},{"key":"policy_57692AA062EC69B3","onyxMethod":"merge","value":{"connections":{"xero":{"config":{"export":{"billDate":"LAST_EXPENSE","billStatus":{"purchase":"AWT_PAYMENT","sales":"AWT_PAYMENT"},"billable":"SALES_INVOICE","exporter":"visaocuoitroi193+10@gmail.com","nonReimbursable":"BANK_TRANSACTION","nonReimbursableAccount":"","reimbursable":"BILL"}}}}}},{"key":"policy_57692AA062EC69B3","onyxMethod":"merge","value":{"connections":{"xero":{"config":{"importCustomers":true}}}}},{"key":"policy_57692AA062EC69B3","onyxMethod":"merge","value":{"connections":{"xero":{"config":{"importTaxRates":false}}}}},{"key":"policy_57692AA062EC69B3","onyxMethod":"merge","value":{"connections":{"xero":{"config":{"importTrackingCategories":true}}}}},{"key":"policy_57692AA062EC69B3","onyxMethod":"merge","value":{"connections":{"xero":{"config":{"isConfigured":false}}}}},{"key":"policy_57692AA062EC69B3","onyxMethod":"merge","value":{"connections":{"xero":{"config":{"mappings":{"customer":"DEFAULT"}}}}}},{"key":"policy_57692AA062EC69B3","onyxMethod":"merge","value":{"connections":{"xero":{"config":{"sync":{"hasChosenAutoSyncOption":true,"hasChosenSyncReimbursedReportsOption":true,"invoiceCollectionsAccountID":"","reimbursementAccountID":"","syncReimbursedReports":true}}}}}},{"key":"policy_57692AA062EC69B3","onyxMethod":"merge","value":{"connections":{"xero":{"data":{"bankAccounts":[],"revenueAccounts":[],"trackingCategories":[]}}}}},{"key":"policy_57692AA062EC69B3","onyxMethod":"merge","value":{"connections":{"xero":{"lastSync":{"errorDate":"","errorMessage":"","isAuthenticationError":false,"isConnected":false,"isSuccessful":false,"source":"","successfulDate":""}}}}}],"eventType":"onyxApiUpdate"}],"lastUpdateID":1408169430,"previousUpdateID":1408168356} 
Log.ts:75 [info] [Report] Handled multipleEvents event sent by Pusher - {"updates":[{"data":[{"key":"policy_57692AA062EC69B3","onyxMethod":"merge","value":{"connections":{"xero":{"config":{"credentials":{"access_token":"OmVpg4a8+OCf9P7I4AoGEQjJuPpM7WqJsxmSjFPUuXAd8nNZT9+rsoVIaUunZVCQODVl7qwM4Lx4iWyF55eY+w/ZUbliljsniSnzeLggWTR/p2h6s6jnw5hxJ1Z+Ngw7U5cdQDim3pQ3/DmJMlG27G8GuQqbALMh6z0A5bjETbtihjB7RbBJl9mCD+wfF+qiA5JC85KAhLhN9k4MsngV8wxG/qoPYUMm2Cv3HZ30PG9Foq+0IaR+/qBc7qEbcatGPJ8tFk/FN90SxjWsAp2r0yq8nzOsJPsZcR8a4Ol/JEECUy8x6AREJAwo8eI/kCdOQX94P5p2UMHK+s/2YE5D+DZzGFh+yI63qXaZv1FkCYRWSoXMLsJExt5jlkO78gnuTh8YSTGSViGlcRgMctxCDtHqLr4WwtBdjtueOIVzlg7c+rUnPzmDGoKnvVbuOlVwDmQJSMLf1e03jb9CtW0+wpd+EtKX4t013LYKyoH8EFXaZZiMgI/t/qDiHLxgtCoFkbWvR0vYJ70vEBqTsOgaVyVKVu7mGUDivDDd2M6bqFSFaUf0jNFsAtltVT2wmf6/Wtelq9JeEStk7jPZ3R2sap4VlqPWPgsCuzTOXHMhvmQuPNIhmFMWBQFdrkNZijVNwP5DFI2g684mEwNmPtDNTT/ZKwCVB3sgQwDGWrsKchK467VmeLJUyFNup9MRPetmOR/iCPqu8Rj0f3ItHNPkAx9cYfOpxGGhORra25zpH1lMKbiUi3ADa6lMeZ+jYjOd97/bEL0w4VjYaeZIHU+qkby2GtAbznkKhQikT00GxJFOGXfGEQmo8EUoeaVtaisuXTPDEBNbimF+hZM81fPYgqDLMks4LwhrQ4m9aUYrMuGpXWB4R1jdOMqw64344e0UFUJ9UvMCUeC5gy70apqgv6LzqNW1t6GlbsYX38XpW42h9PcMHn/OuiaYtezI9JRH7Lgotjz6/RYhH26gWcKuq9eeTPAv+PIN+6vDBi/JQl9OGB1YptgSK1l611Coixxb/S8enJv4g6Ajs0soA7Gzm/YejNgBJKVj0SHIAGhpew3NPPhvCl+vbYM7Z2vXoKgVasntAFZrngzzJnLJS2Lq20FjJtEUi8HMNZ7CVqSW40THl8TZ5pTF8bZRmrmct4HbM+E1FlsgMpMn4v29q7upNr4lu+AvOEaolJOIyMlzdBjyYhlYEqOEqjg6NPKmCx2KqargvNQ9IQHARE6OWdcFgQtK9iJmDvghOungpfvvd8zOTK71w+yx96J2Ssud31X45GwHxlIqfjDZAUNio60rgXpDiTPtJp/7ZYcWh5C5LJO1gMzS68OqFyToZ5eNS2sWCojQhl941ntgwk4+gVEBSOO/5xiguEBrueKoc7DbnCz2VH4OI4ojtrnFtLLv2IsCgc/H72nVMEmrrxzmsXU34bC+NEZ/j1kfYO61Q3165zY0NzgA5ih8LXYFFCsVmDigEGG8YbSW4sr3DHw44repa+SrAIoDWNISIotQXPfovVY9AX3pwMm1AHzZJMgy4giAYbBggp1HYWNKplUY8+HT1+hIeV+6/uj/EbSlRmn5XqQFm/2hUVHhOVrRc5Oj0P6QNU0j3pLeehiax0WnUw4z3pXsrdxxGODt31BA8s/rFKeJ+GCXAVPc1wUnVagFS4Iw1eVkGjCXeXUB1sjcJc8fujH0Damy19zjEJLoKFdoM0bYuyn+w5P42DgTfELabJI0/xA3Wv48NT+WsnlGSMvuaTDt6OH2mvHrnb655wA4wKUSRfgGgBjqp4fHhdlq2j2n875zD3AK0v0p6ff2P1A5wMKoLhzFhh1vAiDJNDP+Ogc=;g4JK0vsb1lWz7ThCG1BkFw==;UvDb7btqYTj6s/YOnYff6r7V9RRm+crJgDhevs7b6dMdfswIk4w9MfF0k2smEzptuL+3vGR76o4IYEhRudK3cA=="}}}}}},{"key":"policy_57692AA062EC69B3","onyxMethod":"merge","value":{"connections":{"xero":{"config":{"credentials":{"refresh_token":"JKCpcHCKzMY7vOII8mlnSalFw3asTiHWgLZ4Ch07N7gb8/ogBsFknUQO4QKUw+iP;oOIqK5eJp9mrYz/FF7C5vQ==;gl2RaPsH1mkjQ4+0hWe79aSnMrrV607Cl8oU7W5weS+vCzneDUpWrVzD8shomggIvpSp0v/A6eppKCn3dJPSSA=="}}}}}},{"key":"policy_57692AA062EC69B3","onyxMethod":"merge","value":{"connections":{"xero":{"data":{"countryCode":"VN"}}}}},{"key":"policy_57692AA062EC69B3","onyxMethod":"merge","value":{"connections":{"xero":{"data":{"organisationID":"d98ac19e-d0a4-47ff-b798-e902b46605e5"}}}}},{"key":"policy_57692AA062EC69B3","onyxMethod":"merge","value":{"connections":{"xero":{"data":{"revenueAccounts":[{"id":"9ae129c6-f457-4a01-8f6b-1fc1198ebb87","name":"Owner A Drawings"},{"id":"77c628a0-1b47-4c96-ac04-2d810412b0c8","name":"Owner A Funds Introduced"},{"id":"05c8356b-5637-4cdd-b821-de0daab2140f","name":"Owner A Share Capital"}]}}}}},{"key":"policy_57692AA062EC69B3","onyxMethod":"merge","value":{"connections":{"xero":{"data":{"tenants":[{"id":"d98ac19e-d0a4-47ff-b798-e902b46605e5","name":"TESST TENANT","value":"!PwkV1"}]}}}}},{"key":"policy_57692AA062EC69B3","onyxMethod":"merge","value":{"connections":{"xero":{"lastSync":{"isConnected":true}}}}},{"key":"policy_57692AA062EC69B3","onyxMethod":"merge","value":{"connections":{"xero":{"lastSync":{"isSuccessful":true}}}}},{"key":"policy_57692AA062EC69B3","onyxMethod":"merge","value":{"connections":{"xero":{"lastSync":{"source":"NEWEXPENSIFY"}}}}},{"key":"policy_57692AA062EC69B3","onyxMethod":"merge","value":{"connections":{"xero":{"lastSync":{"successfulDate":"2024-08-26T14:42:51+0000"}}}}}],"eventType":"onyxApiUpdate"}],"lastUpdateID":1408170694,"previousUpdateID":1408169817}

arosiclair · 2024-08-28T16:10:23Z

Thanks I'm looking into it now. I think I can reproduce as well.

src/libs/actions/connections/index.ts

Add suggestions Co-authored-by: Andrew Rosiclair <arosiclair@gmail.com>

hungvu193 · 2024-08-28T17:51:59Z

It's working fine after latest changes, @getusha would you mind to retest it? ty 😄

hungvu193 · 2024-08-30T02:28:23Z

little bump @getusha, it's close to merge

trjExpensify · 2024-09-02T12:47:41Z

@hungvu193 conflicts to fix here. Thanks!

…-44148

hungvu193 · 2024-09-02T12:53:02Z

@hungvu193 conflicts to fix here. Thanks!

Conflicts resolved. This PR should be read for your review again @getusha

src/libs/actions/connections/index.ts

OSBotify · 2024-09-02T18:41:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-02T23:44:46Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.0.28-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-09-03T23:25:23Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.28-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

only show error message if isSuccessful is false

d7b8835

hungvu193 added 13 commits August 19, 2024 17:53

introduce allConnectionProgreses Onyx data

5a9bf32

fix linting

c1c7d63

fix lint

e353d5a

remove unused import

4dd85ef

update return value

5cf0bfd

update accounting page

c1e7e9c

refactor hasSync logic

5613c04

update the workspacelist logic

6abc5e9

fix linting

5bf86d5

Merge remote-tracking branch 'origin/main' into fix-44148

a0def95

add import connection for list page

266526d

fix lint

2f0d0fa

fix typo in Indicator page

c739923

hungvu193 commented Aug 19, 2024

View reviewed changes

src/libs/WorkspacesSettingsUtils.ts Show resolved Hide resolved

hungvu193 marked this pull request as ready for review August 19, 2024 16:18

hungvu193 requested a review from a team as a code owner August 19, 2024 16:18

melvin-bot bot requested review from getusha and removed request for a team August 19, 2024 16:18

run prettier

9b989d3

arosiclair reviewed Aug 19, 2024

View reviewed changes

remove unused variable

dc6eef6

war-in approved these changes Aug 20, 2024

View reviewed changes

src/pages/workspace/accounting/PolicyAccountingPage.tsx Show resolved Hide resolved

resolve: bad merge

3e035c3

Merge remote-tracking branch 'origin/main' into fix-44148

b5464d0

arosiclair requested changes Aug 28, 2024

View reviewed changes

src/libs/actions/connections/index.ts Outdated Show resolved Hide resolved

hungvu193 and others added 2 commits August 29, 2024 00:06

Update src/libs/actions/connections/index.ts

b661441

Add suggestions Co-authored-by: Andrew Rosiclair <arosiclair@gmail.com>

sync main

b28790f

Merge remote-tracking branch 'origin/main' into fix-44148

32e5a13

hungvu193 added 2 commits September 2, 2024 19:52

fix conflict

58d6421

Merge branch 'fix-44148' of https://github.com/hungvu193/App into fix…

e1d9d43

…-44148

getusha reviewed Sep 2, 2024

View reviewed changes

src/libs/actions/connections/index.ts Show resolved Hide resolved

getusha approved these changes Sep 2, 2024

View reviewed changes

melvin-bot bot requested a review from arosiclair September 2, 2024 16:33

arosiclair approved these changes Sep 2, 2024

View reviewed changes

arosiclair merged commit 73bcfea into Expensify:main Sep 2, 2024
17 of 23 checks passed

github-actions bot mentioned this pull request Sep 2, 2024

Deploy Checklist: New Expensify 2024-09-02 #48438

Closed

46 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix GBR and error briefly show after connecting to QBO, Xero. #47483

Fix GBR and error briefly show after connecting to QBO, Xero. #47483

hungvu193 commented Aug 15, 2024 •

edited

Loading

hungvu193 commented Aug 15, 2024

melvin-bot bot commented Aug 19, 2024

hungvu193 commented Aug 19, 2024 •

edited

Loading

arosiclair left a comment

hungvu193 commented Aug 20, 2024

getusha commented Aug 20, 2024

war-in left a comment

hungvu193 commented Aug 20, 2024

arosiclair commented Aug 20, 2024

getusha commented Aug 25, 2024

hungvu193 commented Aug 25, 2024

getusha commented Aug 25, 2024

hungvu193 commented Aug 25, 2024

hungvu193 commented Aug 25, 2024

arosiclair commented Aug 26, 2024

hungvu193 commented Aug 26, 2024 •

edited

Loading

hungvu193 commented Aug 26, 2024

arosiclair commented Aug 28, 2024

hungvu193 commented Aug 28, 2024

hungvu193 commented Aug 30, 2024

trjExpensify commented Sep 2, 2024

hungvu193 commented Sep 2, 2024

OSBotify commented Sep 2, 2024

OSBotify commented Sep 2, 2024

OSBotify commented Sep 3, 2024

Fix GBR and error briefly show after connecting to QBO, Xero. #47483

Fix GBR and error briefly show after connecting to QBO, Xero. #47483

Conversation

hungvu193 commented Aug 15, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

hungvu193 commented Aug 15, 2024

melvin-bot bot commented Aug 19, 2024

hungvu193 commented Aug 19, 2024 • edited Loading

arosiclair left a comment

Choose a reason for hiding this comment

hungvu193 commented Aug 20, 2024

getusha commented Aug 20, 2024

war-in left a comment

Choose a reason for hiding this comment

hungvu193 commented Aug 20, 2024

arosiclair commented Aug 20, 2024

getusha commented Aug 25, 2024

hungvu193 commented Aug 25, 2024

getusha commented Aug 25, 2024

hungvu193 commented Aug 25, 2024

hungvu193 commented Aug 25, 2024

arosiclair commented Aug 26, 2024

hungvu193 commented Aug 26, 2024 • edited Loading

hungvu193 commented Aug 26, 2024

arosiclair commented Aug 28, 2024

hungvu193 commented Aug 28, 2024

hungvu193 commented Aug 30, 2024

trjExpensify commented Sep 2, 2024

hungvu193 commented Sep 2, 2024

OSBotify commented Sep 2, 2024

OSBotify commented Sep 2, 2024

OSBotify commented Sep 3, 2024

hungvu193 commented Aug 15, 2024 •

edited

Loading

hungvu193 commented Aug 19, 2024 •

edited

Loading

hungvu193 commented Aug 26, 2024 •

edited

Loading