Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Revert "Fix message highlight stuck when open the 2nd context menu" #47718

Merged
merged 1 commit into from
Aug 20, 2024
Merged

[CP Staging] Revert "Fix message highlight stuck when open the 2nd context menu" #47718

merged 1 commit into from
Aug 20, 2024

Conversation

luacmartins
Copy link
Contributor

@luacmartins luacmartins commented Aug 20, 2024 •
edited
Loading

Reverts #47486

Fixed issue

$ #47659

@luacmartins luacmartins self-assigned this Aug 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/47718/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/47718/index.html
Android iOS
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/47718/NewExpensify.dmg https://47718.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

Julesssss
Julesssss reviewed Aug 20, 2024
View reviewed changes
Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue resolved for me. @luacmartins can this be unheld?

@luacmartins luacmartins marked this pull request as ready for review August 20, 2024 18:52
@luacmartins luacmartins requested a review from a team as a code owner August 20, 2024 18:52
@luacmartins luacmartins changed the title Revert "Fix message highlight stuck when open the 2nd context menu" [CP Staging] Revert "Fix message highlight stuck when open the 2nd context menu" Aug 20, 2024
@melvin-bot melvin-bot bot requested review from techievivek and removed request for a team August 20, 2024 18:53
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 20, 2024

@techievivek Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@luacmartins
Copy link
Contributor Author

luacmartins commented Aug 20, 2024 •
edited
Loading

Merging without checklist since it's a straight revert

@luacmartins luacmartins merged commit 5229654 into main Aug 20, 2024
13 of 17 checks passed
@luacmartins luacmartins deleted the revert-47486-fix/45524-message-highlight-is-stukck branch August 20, 2024 18:53
@melvin-bot melvin-bot bot added the Emergency label Aug 20, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 20, 2024

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@luacmartins
Copy link
Contributor Author

See above

OSBotify pushed a commit that referenced this pull request Aug 20, 2024
@luacmartins @OSBotify
Merge pull request #47718 from Expensify/revert-47486-fix/45524-messa…
f576235 
…ge-highlight-is-stukck

[CP Staging] Revert "Fix message highlight stuck when open the 2nd context menu"

(cherry picked from commit 5229654)

(CP triggered by luacmartins)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Aug 20, 2024
@github-actions github-actions bot mentioned this pull request Aug 20, 2024
Closed
77 tasks
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.0.22-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.22-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

bernhardoj added a commit to bernhardoj/Expensify that referenced this pull request Aug 26, 2024
@bernhardoj
Revert "Merge pull request Expensify#47718 from Expensify/revert-4748…
fe67541 
…6-fix/45524-message-highlight-is-stukck"
@github-actions github-actions bot mentioned this pull request Aug 28, 2024
Closed
93 tasks
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.0.26-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.26-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julesssss Julesssss Julesssss approved these changes

@techievivek techievivek Awaiting requested review from techievivek

Assignees

@luacmartins luacmartins

Labels
CP Staging marks PRs that have been CP'd to staging Ready To Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luacmartins @OSBotify @Julesssss