-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bold tag isn't rendered as markdown when it has a style #47764
Fix bold tag isn't rendered as markdown when it has a style #47764
Conversation
@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
I have another PR here that updates expensify-common to 2.0.76. We need to hold on to that. |
We can close this right? Other PR has merged |
…oesnt-render-it-as-bold
@rushatgabhane We still need this PR to update it to 2.0.77. I have taken out the HOLD from the title |
Reviewer Checklist
Screenshots/VideosAndroid: mWeb ChromeiOS: NativeScreen.Recording.2024-08-27.at.20.24.19.moviOS: mWeb SafariScreen.Recording.2024-08-27.at.20.22.08.movMacOS: Chrome / SafariScreen.Recording.2024-08-27.at.19.41.08.movMacOS: DesktopScreen.Recording.2024-08-27.at.19.41.20.mov |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.0.26-1 🚀
|
Failing with original KI in mweb #46891 |
@kavimuru looks like you are copying the text from the Slack app. Can you try doing it from the Slack website? |
🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.26-6 🚀
|
Details
Copying bold markdown from another app, for example, Slack, and pasting it into the app will result in plain text. This PR fix it.
Fixed Issues
$ #46891
PROPOSAL: #46891 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios.mweb.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4