-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add last 4 digits to card list #47773
Conversation
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/Videos |
You should add this in the Tests area: **Precondition**: User account needs to have a few cards added.
1. Login into the app.
2. In the URL bar navigate to `/search/filters/card` (add this after domain eg. https://staging.new.expensify.com).
3. Verify that the cards in the list have a subtitle indicating the last four digits the card is ending in. cc @daledah |
Thanks, @ikevin127. My apologies. I will make sure not to make the same mistake again in the future. |
We got confirmation from design that we want to use |
@ikevin127 I updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 All issues were addressed, translation was confirmed and added.
PR looks good for merge!
We got conflicts @daledah |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
@luacmartins The above-reported performance issue was caused by another PR (#46645) for which I just reviewed the fix PR (#47891) today which is pending performance testing and merge. The same report was posted on all recently merged PRs which are in sync with main. |
Thanks @ikevin127! I removed the blocker label. |
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.25-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.25-0 🚀
|
Details
Fixed Issues
$ #47324
PROPOSAL: #47324 (comment)
Tests
Precondition: User account needs to have a few cards added.
/search/filters/card
(add this after domain eg. https://staging.new.expensify.com).Offline tests
QA Steps
Precondition: User account needs to have a few cards added.
/search/filters/card
(add this after domain eg. https://staging.new.expensify.com).PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-08-21.at.14.42.53.mov
Android: mWeb Chrome
Screen.Recording.2024-08-21.at.14.40.28.mov
iOS: Native
Screen.Recording.2024-08-21.at.14.48.00.mov
iOS: mWeb Safari
Screen.Recording.2024-08-21.at.14.45.17.mov
MacOS: Chrome / Safari
Screen.Recording.2024-08-21.at.14.33.38.mov
MacOS: Desktop
Screen.Recording.2024-08-21.at.14.53.46.mov