-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: open bank account step directly in bottom down flow #48006
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and makes sense 👍
I think it would also be good to take a look why we are calling OpenReport and ReadNewestAction api commands. Seems unnecessary to me
@MonilBhavsar when creating the new workspace we are navigating to it. Thus we call |
In this case, we're not redirecting. Are we? Then how are we calling the API commands, while the modal is still loading 🤔 |
We are 😊 can share a video in a moment |
I hope my mouse pointer annotations make it obvious what I mean 😄: Screen.Recording.2024-08-26.at.20.27.46.mov |
Oh I see now. Makes sense. Thank you! 😄 |
PR is ready for testing now! (Just need to test/upload android screenshots, still running a new build) // All done now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach looks good to me in general. @getusha what is your eta for the checklist? thanks!
Max 3 hours, i am on it. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-08-27.at.12.50.29.in.the.afternoon.movAndroid: mWeb ChromeScreen.Recording.2024-08-27.at.12.37.58.in.the.afternoon.moviOS: NativeScreen.Recording.2024-08-27.at.1.01.10.in.the.afternoon.moviOS: mWeb SafariScreen.Recording.2024-08-27.at.12.48.38.in.the.afternoon.movMacOS: Chrome / SafariScreen.Recording.2024-08-27.at.12.33.26.in.the.afternoon.movMacOS: DesktopScreen.Recording.2024-08-27.at.1.02.36.in.the.afternoon.mov |
The bank account step doesn't open instantly from workspace chat after fresh login Screen.Recording.2024-08-27.at.2.10.23.in.the.afternoon.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we update the onyx value immediately before navigating to that page, so it must be some JS slowness that the value isn't set immediately when we are on the page. My hope is that in release mode the app will work a bit faster and that it won't be noticeable that much 😅 |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.26-1 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.26-6 🚀
|
Details
There is an issue where when creating a workspace from an IOU as part of the bottom up flow the opening of the plaid modal takes a long time.
The problem is that the ReimbursmentAccountPage depends on the
openReimbursementAccountPage
command, which can be delayed due to all intermediate calls that happen we create a new workspace (e.g.OpenReport
).For the aforementioned workflow we don't need to wait for
openReimbursementAccountPage
as we know that in this new workspace no bank account is setup.The solution was to set the onyx reimbursement account state to be directly in the bank account setup step once we created a new workspace from IOU.
Note: There was one typescript issue with the ACHData where for an reimbursement account the step and subStep can be an empty string. Had to fix that as well here.
before.mov
after.mov
TODO:
createWorkspaceFromIOUPayment
(checks if implementation would break any other flow)Fixed Issues
$ #42756
discussion https://expensify.slack.com/archives/C05LX9D6E07/p1724434828202709
PROPOSAL: https://expensify.slack.com/archives/C05LX9D6E07/p1724673925409079?thread_ts=1724434828.202709&cid=C05LX9D6E07
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-08-26.at.21.28.26.mov
Android: mWeb Chrome
Screen.Recording.2024-08-26.at.21.11.36.mov
iOS: Native
Screen.Recording.2024-08-26.at.21.12.06.mov
iOS: mWeb Safari
ios_mWeb.mov
MacOS: Chrome / Safari
after.mov
MacOS: Desktop
Screen.Recording.2024-08-26.at.20.46.27.mov