-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update Wallet and Generic Folder empty state to use lottie animations. #48040
Changes from all commits
c49cd8f
8708b2e
795eb09
38a4e54
6616c56
168fb04
c1aef41
4741b8c
624fe06
d37d786
a1a507f
038c6e8
71003f4
d8aa227
229b8e3
33dd33b
5c13a44
36fb0b4
26bf428
76e7cbb
b9f96d3
46ca8c7
975164b
857a8c5
7bf97fa
3dda855
115b2fc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4727,8 +4727,7 @@ const styles = (theme: ThemeColors) => | |
}, | ||
|
||
walletIllustration: { | ||
width: 262, | ||
height: 152, | ||
height: 180, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. May I know why do you remove the width here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess the animation wasn't displayed correctly with the width, so I had to remove that. |
||
}, | ||
|
||
walletCardLimit: { | ||
|
@@ -5076,6 +5075,8 @@ const styles = (theme: ThemeColors) => | |
|
||
emptyStateCardIllustrationContainer: { | ||
height: 220, | ||
...flex.alignItemsCenter, | ||
...flex.justifyContentCenter, | ||
}, | ||
|
||
emptyStateCardIllustration: { | ||
|
@@ -5113,11 +5114,6 @@ const styles = (theme: ThemeColors) => | |
textDecorationLine: 'line-through', | ||
}, | ||
|
||
tripIllustrationSize: { | ||
width: 190, | ||
height: 172, | ||
}, | ||
|
||
reportListItemTitle: { | ||
color: theme.text, | ||
fontSize: variables.fontSizeNormal, | ||
|
@@ -5163,14 +5159,27 @@ const styles = (theme: ThemeColors) => | |
backgroundColor: theme.emptyFolderBG, | ||
}, | ||
|
||
emptyFolderDarkBG: { | ||
backgroundColor: '#782c04', | ||
height: 220, | ||
}, | ||
|
||
emptyStateVideo: { | ||
borderTopLeftRadius: variables.componentBorderRadiusLarge, | ||
borderTopRightRadius: variables.componentBorderRadiusLarge, | ||
}, | ||
|
||
emptyStateFolderIconSize: { | ||
width: 184, | ||
height: 112, | ||
emptyStateFolderWithPaperIconSize: { | ||
width: 160, | ||
height: 100, | ||
}, | ||
|
||
emptyStateFolderWebStyles: { | ||
...sizing.w100, | ||
minWidth: 400, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Krishna2323 Friendly reminder that you need to make sure you test this one on smaller device like iPhone8 or iPhoneSE There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, thanks for the reminder. I tested on the web by resizing, but I still need to test on all platforms. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @hungvu193, tested on all platforms. I think you start reviewing now. Monosnap.screencast.2024-09-20.04-45-12.mp4There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks man! Appreciate it, I'll give it a final review today! |
||
...flex.alignItemsCenter, | ||
...flex.justifyContentCenter, | ||
...display.dFlex, | ||
}, | ||
|
||
workflowApprovalVerticalLine: { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB because it seems like all the styles are right in the screen recordings, but I think we might be able to use
shouldUseNarrowLayout
here, and generally that should be the default go-to instead ofisSmallScreenWidth