-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added count param to phrase param and return plural form accordingly #48229
Merged
iwiznia
merged 48 commits into
Expensify:main
from
ZhenjaHorbach:pluralizing_localization-v2
Sep 26, 2024
Merged
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
736b250
update TranslationBase and make few changes
ZhenjaHorbach 9d42d55
fix conflicts
ZhenjaHorbach e830bb5
update TranslationBase
ZhenjaHorbach 09f51d4
update translations PART-1
ZhenjaHorbach a237886
update translations PART-2
ZhenjaHorbach d0bf65b
update translations PART-3
ZhenjaHorbach 41f0334
update translations PART-4
ZhenjaHorbach 078a5ad
Merge branch 'main' into pluralizing_localization-v2
ZhenjaHorbach b70f5e4
update TranslationBase type
ZhenjaHorbach f31c7f2
fix conflicts
ZhenjaHorbach af67cd0
fix conflicts
ZhenjaHorbach eab923d
fix conflicts
ZhenjaHorbach 5d1a70c
update new translations
ZhenjaHorbach 41a3199
update TranslationBaseValue
ZhenjaHorbach 8ebf751
revert some changes
ZhenjaHorbach 273c8e1
revert some changes
ZhenjaHorbach d63aa0d
update type arguments
ZhenjaHorbach 4b7eb6d
fix conflicts
ZhenjaHorbach 57d8b7f
fix ts issues
ZhenjaHorbach 83481bf
fix ts issue with no string values
ZhenjaHorbach 554611c
fix conflicts
ZhenjaHorbach 7c24bb4
update types for translations
ZhenjaHorbach d3028b6
refactor TranslationBase
ZhenjaHorbach 100feae
refactor some code
ZhenjaHorbach 87fd61d
fix conflicts
ZhenjaHorbach 101fd03
refactor types for translations
ZhenjaHorbach 90af317
update types
ZhenjaHorbach 362c264
fix issue with no object values
ZhenjaHorbach 8f58c9e
fix ts issue in localize
ZhenjaHorbach 04c8f76
fix comments
ZhenjaHorbach bd485f9
fix conflicts
ZhenjaHorbach 5d73e02
fix conflicts
ZhenjaHorbach 0002662
fix conflicts
ZhenjaHorbach 4e0d494
fix conflicts
ZhenjaHorbach 2b84c98
fix conflicts
ZhenjaHorbach 2175302
update package-lock
ZhenjaHorbach d7f49e5
update package-lock x2
ZhenjaHorbach 090af99
fix comments
ZhenjaHorbach e278f17
fix conflicts
ZhenjaHorbach be492c0
fix conflicts
ZhenjaHorbach 94d170b
fix conflicts
ZhenjaHorbach ffcd48e
update branch
ZhenjaHorbach 480bdda
fix some comments
ZhenjaHorbach 1ebfb54
update readme
ZhenjaHorbach 27b7056
update readme x2
ZhenjaHorbach 7638a4c
update localize comment
ZhenjaHorbach 12b3b41
fix comments
ZhenjaHorbach a36a304
refactor plural forms
ZhenjaHorbach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh crap, did not really notice this before... does the object containing the messages always need to be a function or can it also be:
There's really no need for a function there...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, since it will be impossible to differentiate between
messages
andmessages.one
translation key in a flat object.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation looks like any other object with translations
And not a specific translation with plural forms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get this
Yeah, so?
Anyway, it would be nice if we supported the simple object notation too, but not going to block on that since this is a big PR, we've been waiting a long time for it and adding the function is not that bad.