Hide mobile Search nav button + status tabs on scrollDown, but reveal on scrollUp #48258

SzymczakJ · 2024-08-29T12:06:44Z

Details

This PR adds an animation that hides mobile Search nav bar on scroll down and reveals it on scrollUp. Please note that this feature is only meant to work on mobile screens. Also when user doesn't have enough expenses, the bar won't hide.

Fixed Issues

$ #48019
PROPOSAL:

Tests

Go to Search tab that has a lot of expenses.
Try scrolling and make sure expense type and status bar hides and shows properly.
Go to Search tab that has little or no expenses.
Make sure and make sure expense type and status bar is locked in place.

Offline tests

QA Steps

Same as test steps

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

androidweb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

iosweb.mov

MacOS: Chrome / Safari

MacOS: Desktop

Guccio163

generally LGTM, works great! 👀

Kicu

Hey very nice work both on animation and refactoring. SearchPageHeader feels much simpler, and also Search component also looks simpler.

My only real problem is with SearchPageBottom because it became harder to read.
Most of my comments are minor naming issues, LGTM otherwise 👍

src/pages/Search/SearchPageBottomTab.tsx

src/components/Search/index.tsx

src/components/Search/SearchStatusBar.tsx

Kicu · 2024-09-03T15:10:48Z

src/components/Search/SearchPageHeader.tsx

    isCustomQuery: boolean;
-    setOfflineModalOpen?: () => void;
-    setDownloadErrorModalOpen?: () => void;
-    data?: TransactionListItemType[] | ReportListItemType[];


great job removing so many props! 👏

src/components/Search/index.tsx

src/components/SelectionList/index.tsx

src/libs/SearchUtils.ts

Kicu · 2024-09-03T15:24:01Z

src/pages/Search/SearchPageBottomTab.tsx

+                                hash={queryJSON.hash}
+                                isCustomQuery={isCustomQuery}
+                            />
+                        )}


Do you think its possible to somehow simplify this and reduce the amount of conditional rendering inside this return?
We have conditional rendering for TopBar + SearchTypeMenu, then extra condition for SearchStatusBar and all that is exclusive with SearchPageHeader rendering.
It's very hard to understand which parts of the UI will be rendered.

Some ideas:

early returns?

saving parts of JSX to variables?

small helper components declared within this file?

I think you could try to go over this code again and see if anything can be improved.

melvin-bot · 2024-09-04T09:06:02Z

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2024-09-04T10:23:30Z

Running a test build for easier testing...

shawnborton · 2024-09-04T10:42:27Z

Any idea how to fix the iOS build above so we can test?

SzymczakJ · 2024-09-04T12:10:11Z

I merged main and the error should be solved(ruby-version file was missing, but it was reintroduced after merge). Can you try again?

shawnborton · 2024-09-04T12:12:00Z

Will do!

github-actions · 2024-09-04T12:51:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/48258/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/48258/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/48258/NewExpensify.dmg	https://48258.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

dannymcclain · 2024-09-04T13:58:24Z

I think this is feeling pretty darn good!

SzymczakJ · 2024-09-17T07:49:32Z

I messed something up with merging. Will fix it in 5 minutes.
What about the thing that Jon said? @shawnborton

shawnborton · 2024-09-17T07:55:19Z

I addressed Jon's comment above. Let's see what Danny thinks. I don't mind how it is working now though, I could totally get down with it's current behavior.

SzymczakJ · 2024-09-17T13:37:35Z

@dannymcclain we need your opinion here! 😄

dannymcclain · 2024-09-17T13:37:44Z

🫣 I kinda like the quick appear. But I will also add that I don't think there's a right answer here—both behaviors are totally totally valid. Like Shawn noted, I've seen and used both behaviors out in the wild and neither are "bad".

@dubielzyk-expensify if you feel strongly about changing the incoming animation, I am totally good with that. I don't feel insanely strongly because like I said, I think both approaches are good. If we want to get this behavior merged as is and come back to it, that's totally fine too.

What I like about the quick appear is that (for me personally) I'm likely scrolling up to get to those options, so getting them in front of me quickly is nice. I think I've also mentioned this before, but the quick appear also (again, for me) signals that this menu is being overlaid on top of the list and is not part of the list. So I know there's more expenses "under" it if I keep scrolling up.

dannymcclain · 2024-09-17T13:39:14Z

lol ask and you shall receive! 😁

dubielzyk-expensify · 2024-09-18T03:15:34Z

I'm happy to move forward with this 😄

SzymczakJ · 2024-09-18T07:25:56Z

Nice! Then this is ready for your review @rayane-djouah

luacmartins · 2024-09-18T23:21:36Z

Nice! It's looking really good. @rayane-djouah let's start reviewing this one

rayane-djouah · 2024-09-19T01:35:18Z

Will review this first thing in my morning

src/components/Search/SearchContext.tsx

src/components/Search/SearchPageHeader.tsx

src/components/Search/index.tsx

rayane-djouah · 2024-09-19T10:42:36Z

src/components/SelectionList/index.tsx

@@ -27,18 +27,20 @@ function SelectionList<TItem extends ListItem>(props: BaseSelectionListProps<TIt
        };
    }, []);

+    const defaultOnScroll = () => {


Suggested change

const defaultOnScroll = () => {

const dismissKeyboard = () => {

src/components/Search/SearchContext.tsx

src/styles/index.ts

@@ -3610,6 +3610,14 @@ const styles = (theme: ThemeColors) =>
            fontWeight: FontUtils.fontWeight.bold,
        },



src/pages/Search/SearchPageBottomTab.tsx

rayane-djouah · 2024-09-19T12:01:25Z

src/pages/Search/SearchSelectedModeHeader.tsx

Let's rename the file to SearchSelectionModeHeader.tsx

rayane-djouah · 2024-09-19T12:11:37Z

src/pages/Search/SearchPageBottomTab.tsx

 import SearchTypeMenu from './SearchTypeMenu';

+const TOO_CLOSE_TO_TOP_DISTANCE = 5;
+const TOO_CLOSE_TO_BOTTOM_DISTNACE = 10;


Suggested change

const TOO_CLOSE_TO_BOTTOM_DISTNACE = 10;

const TOO_CLOSE_TO_BOTTOM_DISTANCE = 10;

We still have this typo 😄

rayane-djouah · 2024-09-19T22:10:00Z

src/components/Search/SearchPageHeader.tsx

Bug on small screens: Selected multiple expenses and clicked "delete," but the delete confirmation modal did not appear.

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-09-19.at.23.02.42.mp4

rayane-djouah

Bug: The app crash on Android native when we open the search page:

Screenshot

SzymczakJ · 2024-09-20T17:37:18Z

fixed your comments @rayane-djouah!

rayane-djouah · 2024-09-20T17:47:37Z

src/components/SelectionList/index.tsx

-                }
-                Keyboard.dismiss();
-            }}
+            onScroll={onScroll ?? defaultOnScroll}


@SzymczakJ Can we use dismissKeyboard in onScrollBeginDrag and our custom onScroll in onScroll?

rayane-djouah · 2024-09-20T17:48:09Z

src/pages/Search/SearchPageBottomTab.tsx

 import SearchTypeMenu from './SearchTypeMenu';

+const TOO_CLOSE_TO_TOP_DISTANCE = 5;
+const TOO_CLOSE_TO_BOTTOM_DISTNACE = 10;


We still have this typo 😄

rayane-djouah · 2024-09-21T15:29:54Z

Bug: Status bar is not scrollable on the Android native app

rayane-djouah · 2024-09-21T16:12:13Z

Bug: We have some spacing inconsistency:

Staging	Dev (This PR)
The status bar has a `20px` bottom margin	The status bar has an `8px` bottom margin

Staging	Dev (This PR)
The skeleton list doesn't have a top margin, and the status bar has a `20px` bottom margin	The skeleton list has a `12px` top margin, and the status bar has an `8px` bottom margin, this causes the empty state view to move `8px` to the top

Staging	Dev (This PR)
The skeleton list doesn't have a top margin, and the status bar has a `20px` bottom margin	The skeleton list has a `12px` top margin, and the status bar has a `20px` bottom margin => `32px` total

rayane-djouah · 2024-09-21T16:17:06Z

Not sure which one is correct:

Staging	Dev (This PR)
The status bar is displayed in the selection mode	The status bar is not displayed in the selection mode

SzymczakJ · 2024-09-23T12:08:02Z

Not sure which one is correct:

We've agreed upon second version here #48019 (comment)

SzymczakJ · 2024-09-23T12:29:39Z

Fixed your comments @rayane-djouah!
PS. Awesome review 😃

SzymczakJ added 3 commits August 29, 2024 13:51

add animation logic

0cdffe1

Merge branch 'main' into @szymczak/search-bar-hiding

ce6f1cc

prettify code

6ea15d8

Guccio163 approved these changes Aug 30, 2024

View reviewed changes

SzymczakJ added 7 commits September 2, 2024 10:46

adjust padding

ec1402b

Merge branch 'main' into @szymczak/search-bar-hiding

c2cb62e

make SearchPageHeader use SearchContext instead of accepting data param

e93ceca

move modals from Search/index to SearchPageHeader

1e5ff51

fix paddings

cd01f44

fix EmptyState and Loading screen paddings

ce7d213

fix loading state bug

709e93d

Kicu suggested changes Sep 3, 2024

View reviewed changes

SzymczakJ added 3 commits September 3, 2024 18:26

fix PR comments

317cc9e

Merge branch 'main' into @szymczak/search-bar-hiding

8fd252b

fix typo in comment

8794f8c

SzymczakJ marked this pull request as ready for review September 4, 2024 09:05

SzymczakJ requested review from a team as code owners September 4, 2024 09:05

melvin-bot bot requested review from rayane-djouah and removed request for a team September 4, 2024 09:06

shawnborton added the Ready To Build label Sep 4, 2024

This comment has been minimized.

Sign in to view

Merge branch 'main' into @szymczak/search-bar-hiding

261df38

fix empty state not showing

a51f7db

SzymczakJ added 4 commits September 18, 2024 08:46

clean up code

8319d34

Merge branch 'main' into @szymczak/search-bar-hiding

9b7e621

clean up code

487945d

fix styles

7146a1d

rayane-djouah suggested changes Sep 19, 2024

View reviewed changes

rayane-djouah reviewed Sep 19, 2024

View reviewed changes

SzymczakJ added 4 commits September 20, 2024 18:31

fix PR comments

91e44d4

Merge branch 'main' into @szymczak/search-bar-hiding

0a672cf

fix PR comments

786c2cb

fix modal not showing bug

3d556e4

rayane-djouah suggested changes Sep 20, 2024

View reviewed changes

fix PR comments

009d3d3

fix margin

3fd8995

	const defaultOnScroll = () => {
	const dismissKeyboard = () => {

		@@ -3610,6 +3610,14 @@ const styles = (theme: ThemeColors) =>
		fontWeight: FontUtils.fontWeight.bold,
		},

	const TOO_CLOSE_TO_BOTTOM_DISTNACE = 10;
	const TOO_CLOSE_TO_BOTTOM_DISTANCE = 10;

Hide mobile Search nav button + status tabs on scrollDown, but reveal on scrollUp #48258

Are you sure you want to change the base?

Hide mobile Search nav button + status tabs on scrollDown, but reveal on scrollUp #48258

Conversation

SzymczakJ commented Aug 29, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Guccio163 left a comment

Choose a reason for hiding this comment

Kicu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

melvin-bot bot commented Sep 4, 2024

shawnborton commented Sep 4, 2024

This comment has been minimized.

shawnborton commented Sep 4, 2024

SzymczakJ commented Sep 4, 2024

shawnborton commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

dannymcclain commented Sep 4, 2024

SzymczakJ commented Sep 17, 2024

shawnborton commented Sep 17, 2024

SzymczakJ commented Sep 17, 2024

dannymcclain commented Sep 17, 2024

dannymcclain commented Sep 17, 2024

dubielzyk-expensify commented Sep 18, 2024

SzymczakJ commented Sep 18, 2024

luacmartins commented Sep 18, 2024

rayane-djouah commented Sep 19, 2024

Choose a reason for hiding this comment

This comment was marked as resolved.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rayane-djouah left a comment • edited Loading

Choose a reason for hiding this comment

SzymczakJ commented Sep 20, 2024

rayane-djouah Sep 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rayane-djouah commented Sep 21, 2024

rayane-djouah commented Sep 21, 2024

rayane-djouah commented Sep 21, 2024

SzymczakJ commented Sep 23, 2024

SzymczakJ commented Sep 23, 2024 • edited Loading

SzymczakJ commented Aug 29, 2024 •

edited

Loading

rayane-djouah left a comment •

edited

Loading

rayane-djouah Sep 20, 2024 •

edited

Loading

SzymczakJ commented Sep 23, 2024 •

edited

Loading