Update UpdatePolicyConnectionConfiguration to be 1:1:1 - Part 5 #48277

hoangzinh · 2024-08-29T15:30:53Z

Details

Fixed Issues

$ #47523
PROPOSAL:

Tests

Prerequisite: Your workspace needs to connect with QBO.

Test case 1: UpdateQuickbooksOnlineReceivableAccount

Go to Workspace -> Accounting
Go to Export -> Export invoice to
Choose another account
Verify it saves successfully

Test case 2: UpdateQuickbooksOnlineExportDate

Go to Workspace -> Accounting
Go to Export -> Export date
Change to another export date
Verify it saves successfully

Test case 3: UpdateQuickbooksOnlineNonReimbursableExpensesAccount

Go to Workspace -> Accounting
Go to Export -> Export company card expense as
Change the credit card / bank account / accounts payable option (whatever the second option on the tab is - it changes based on the top "Export as" option)
Verify it saves successfully

Test case 4: UpdateQuickbooksOnlineCollectionAccountID

Go to Workspace -> Accounting
Go to Advanced -> Quickbooks invoice collections account
Change to another option
Verify it saves successfully

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-08-30.at.18.43.45.android.mov

Android: mWeb Chrome

Screen.Recording.2024-08-30.at.18.38.48.android.chrome.mov

iOS: Native

Screen.Recording.2024-08-30.at.18.46.16.ios.mov

iOS: mWeb Safari

Screen.Recording.2024-08-30.at.18.47.54.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-08-30.at.18.28.40.web.mov

MacOS: Desktop

Screen.Recording.2024-08-30.at.18.34.54.desktop.mov

hoangzinh · 2024-08-29T16:13:32Z

Hi @dangrous @aldo-expensify Do you know how to set up "account" in QBO to test API UpdateQuickbooksOnlineReceivableAccount? I tried to add employees and accountants in QBO but it doesn't show in this page.

dangrous · 2024-08-29T17:46:38Z

Hm so I think it means bank account, but I'm looking at QBO and I'm not actually sure how to set those up. If you need, though, we can test in our QA account when you're ready, since that already has bank accounts set up

hoangzinh · 2024-08-30T09:47:02Z

Yes, please thanks @dangrous. So just wanna confirm

I will do test case 2 & 4.
Can you help me do test 1 & 3?

melvin-bot · 2024-08-30T11:50:45Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dangrous · 2024-08-30T14:56:19Z

yep! I can do 1 and 3. Is that ready to go?

hoangzinh · 2024-08-30T15:08:54Z

Yes @dangrous, the PR is ready to review

dangrous · 2024-08-30T17:06:58Z

test 3 works great! I updated the test steps also.

~~test 1 - the test account we use only has one option here, so I can't change it. Going to see if there's another one we can use.~~

EDIT: Test 1 works as well! Video for both is below.

2024-08-30_13-20-12.mp4

hoangzinh · 2024-08-31T00:36:29Z

I appreciate your help @dangrous. @rushatgabhane it's ready for code review.

rushatgabhane · 2024-09-02T23:27:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-15.at.21.06.42.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-09-15.at.20.54.39.mov

iOS: mWeb Safari

Screen.Recording.2024-09-15.at.20.59.16.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-15.at.20.43.11.mov

Screen.Recording.2024-09-15.at.20.46.55.mov

Screen.Recording.2024-09-15.at.20.48.32.mov

MacOS: Desktop

Screen.Recording.2024-09-15.at.21.01.21.mov

…_to_be111

hoangzinh · 2024-09-05T16:09:47Z

Bump @rushatgabhane to review this PR

rushatgabhane · 2024-09-09T18:13:15Z

oh shoot
reviewing today

hoangzinh · 2024-09-12T10:18:58Z

@rushatgabhane any updates on code review?

OSBotify · 2024-09-17T19:30:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-17T20:51:36Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.37-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-09-19T23:33:12Z

🚀 Deployed to production by https://github.com/grgia in version: 9.0.38-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

hoangzinh added 4 commits August 29, 2024 20:30

Update UpdateQuickbooksOnlineReceivableAccount to 1:1:1

1338df1

Update UpdateQuickbooksOnlineExportDate to 1:1:1

c946df9

Update UpdateQuickbooksOnlineNonReimbursableExpensesAccount to 1:1:1

7e9d080

Update UpdateQuickbooksOnlineCollectionAccountID to 1:1:1

7addeb3

hoangzinh marked this pull request as ready for review August 30, 2024 11:50

hoangzinh requested a review from a team as a code owner August 30, 2024 11:50

melvin-bot bot requested review from rushatgabhane and removed request for a team August 30, 2024 11:50

hoangzinh added 4 commits September 4, 2024 23:12

Merge branch 'main' into 47523_update_policy_connection_configuration…

9edbda9

…_to_be111

Merge branch 'main' into 47523_update_policy_connection_configuration…

479ea29

…_to_be111

Pass oldSettingValue

db94778

Change to new constant

4c5afef

dangrous mentioned this pull request Sep 13, 2024

QBO operations 1:1 Part 4 #48080

Merged

49 tasks

rushatgabhane approved these changes Sep 15, 2024

View reviewed changes

melvin-bot bot requested a review from dangrous September 15, 2024 18:00

aldo-expensify approved these changes Sep 16, 2024

View reviewed changes

dangrous approved these changes Sep 17, 2024

View reviewed changes

dangrous merged commit bf81e66 into Expensify:main Sep 17, 2024
17 checks passed

github-actions bot mentioned this pull request Sep 17, 2024

Deploy Checklist: New Expensify 2024-09-17 #49356

Closed

40 tasks

izarutskaya mentioned this pull request Sep 18, 2024

QBO - Changing to other option does not save for the first time #49372

Open

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update UpdatePolicyConnectionConfiguration to be 1:1:1 - Part 5 #48277

Update UpdatePolicyConnectionConfiguration to be 1:1:1 - Part 5 #48277

hoangzinh commented Aug 29, 2024 •

edited by dangrous

Loading

hoangzinh commented Aug 29, 2024

dangrous commented Aug 29, 2024

hoangzinh commented Aug 30, 2024

melvin-bot bot commented Aug 30, 2024

dangrous commented Aug 30, 2024

hoangzinh commented Aug 30, 2024

dangrous commented Aug 30, 2024 •

edited

Loading

hoangzinh commented Aug 31, 2024

rushatgabhane commented Sep 2, 2024 •

edited

Loading

hoangzinh commented Sep 5, 2024

rushatgabhane commented Sep 9, 2024

hoangzinh commented Sep 12, 2024 •

edited

Loading

OSBotify commented Sep 17, 2024

OSBotify commented Sep 17, 2024

OSBotify commented Sep 19, 2024

Update UpdatePolicyConnectionConfiguration to be 1:1:1 - Part 5 #48277

Update UpdatePolicyConnectionConfiguration to be 1:1:1 - Part 5 #48277

Conversation

hoangzinh commented Aug 29, 2024 • edited by dangrous Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

hoangzinh commented Aug 29, 2024

dangrous commented Aug 29, 2024

hoangzinh commented Aug 30, 2024

melvin-bot bot commented Aug 30, 2024

dangrous commented Aug 30, 2024

hoangzinh commented Aug 30, 2024

dangrous commented Aug 30, 2024 • edited Loading

hoangzinh commented Aug 31, 2024

rushatgabhane commented Sep 2, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

hoangzinh commented Sep 5, 2024

rushatgabhane commented Sep 9, 2024

hoangzinh commented Sep 12, 2024 • edited Loading

OSBotify commented Sep 17, 2024

OSBotify commented Sep 17, 2024

OSBotify commented Sep 19, 2024

hoangzinh commented Aug 29, 2024 •

edited by dangrous

Loading

dangrous commented Aug 30, 2024 •

edited

Loading

rushatgabhane commented Sep 2, 2024 •

edited

Loading

hoangzinh commented Sep 12, 2024 •

edited

Loading