Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Disable attachment preview until it's uploaded" #48441

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Revert "Disable attachment preview until it's uploaded" #48441

merged 1 commit into from
Sep 3, 2024

Conversation

roryabraham
Copy link
Contributor

Reverts #48241

@roryabraham roryabraham requested a review from a team as a code owner September 2, 2024 23:46
@melvin-bot melvin-bot bot requested review from Beamanator and removed request for a team September 2, 2024 23:47
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 2, 2024

@Beamanator Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@roryabraham
Copy link
Contributor Author

Brought this up in slack: https://expensify.slack.com/archives/C03U7DCU4/p1725320474731139

@srikarparsi srikarparsi merged commit 0e9f918 into main Sep 3, 2024
13 of 15 checks passed
@srikarparsi srikarparsi deleted the revert-48241-fix/47646-disable-preview-while-uploading branch September 3, 2024 06:31
@melvin-bot melvin-bot bot added the Emergency label Sep 3, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 3, 2024

@srikarparsi looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@srikarparsi
Copy link
Contributor

Removing the emergency label as this was a straight revert

@OSBotify
Copy link
Contributor

OSBotify commented Sep 3, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot mentioned this pull request Sep 3, 2024
Closed
OSBotify pushed a commit that referenced this pull request Sep 3, 2024
@srikarparsi @OSBotify
Merge pull request #48441 from Expensify/revert-48241-fix/47646-disab…
6e2800c 
…le-preview-while-uploading

Revert "Disable attachment preview until it's uploaded"

(cherry picked from commit 0e9f918)

(CP triggered by roryabraham)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Sep 3, 2024
@github-actions github-actions bot mentioned this pull request Sep 3, 2024
Closed
46 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Sep 3, 2024

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.0.28-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Sep 3, 2024

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.28-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikarparsi srikarparsi srikarparsi approved these changes

@Beamanator Beamanator Awaiting requested review from Beamanator

Assignees
No one assigned
Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roryabraham @srikarparsi @OSBotify