Support new action `REMOVED_FROM_APPROVAL_CHAIN` #48508

Beamanator · 2024-09-03T20:56:00Z

cc @marcochavezf since you've been around for a lot of these changes recently :D

Details

Fixed Issues

$ Related to https://github.com/Expensify/Expensify/issues/422963

Tests

Create a Control policy in OldDot, make sure it has policy expense chats enabled, make sure it has "Advanced Approvals" enabled in members tab
- To enable policy expense chats, enter this into the console on the policy screen in OldDot: p = Policy.getCurrent(); p.policy.isPolicyExpenseChatEnabled = "true"; p.save();
In OldDot, invite 6 people as users (non-admins): 3 submitters, 1 initial approver, and 2 final approvers
In members tab in OldDot, make sure each of the submitter's accounts have submitsTo set to the initial approver. The initial approver should have their forwardsTo set to Final Approver 1. Both final approvers should NOT have a forwardsTo set.
Log in to Final Approver 1's account in a different device, open their personal workspace chat for the policy created in step 1
On the original device, log in as the policy owner in OldDot, go to the workspace settings page, to the members settings
- Change the approver's forwardsTo to Final Approver 2
Refresh, then Verify Final Approver 1 gets a whispered report action saying "removed you from approver 1, approver 2 and approver 3's approval workflows and workspace chats. Previously submitted reports will remain available for approval in your Inbox."
Verify Final Approver 1 no longer has access to any submitters' workspace chats

Verify that no errors appear in the JS console

Offline tests

Steps must be completed online since they involve pusher messages sent to some accounts, triggered by other accounts

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…wAction-REMOVEDFROMAPPROVALCHAIN

melvin-bot · 2024-09-06T20:24:18Z

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Beamanator · 2024-09-07T02:47:21Z

I'll fill out the checklist on monday, but this should be good to go!

stitesExpensify

Looks great!

allroundexperts · 2024-09-09T20:22:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-09-11.at.3.47.11.AM.mov

MacOS: Desktop

allroundexperts · 2024-09-09T21:34:20Z

@Beamanator Are the test steps accurate? Aren't many of the features such as approval added to new dot already?

Beamanator · 2024-09-09T21:52:14Z

@allroundexperts true true, you can do pretty much all of the members adding / workflow modifying in NewDot today 👍

Beamanator · 2024-09-10T22:05:13Z

bump @allroundexperts 🙏

…wAction-REMOVEDFROMAPPROVALCHAIN

allroundexperts · 2024-09-10T23:00:47Z

Bug

Given the workspace does not have any expense submitted, and we remove an approver, the whisper does not show up. @Beamanator will investigate this in another issue.

allroundexperts

Looks good!

melvin-bot · 2024-09-10T23:01:32Z

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2024-09-10T23:01:35Z

🎯 @allroundexperts, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #48948.

OSBotify · 2024-09-10T23:36:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Beamanator · 2024-09-11T14:21:09Z

This PR is now in staging - in #48954 👍

Beamanator · 2024-09-12T18:09:09Z

@allroundexperts i haven't been able to reproduce the bug you mentioned here, can you please write exact reproduction steps you took to encounter the issue?

allroundexperts · 2024-09-12T19:29:26Z

Create a new account on new dot.
Create a workspace, and in its settings, enable the advanced approval workflow.
Go to the Workflows tab and add 3 members (1 initial approver and 2 final approvers)
Login as the initial approver in a separate incognito window.
Remove the first initial approver from the first window.
In the incognito window, notice that the user does not get any whisper.

Beamanator added 4 commits September 3, 2024 13:11

New 'removed from approval chain' report action & type

edd2c9e

Add action message translations

4b57ce8

Update spanish copy

366fd89

Build action message correctly

fecc14c

Beamanator self-assigned this Sep 3, 2024

Beamanator added 12 commits September 5, 2024 09:06

Merge branch 'main' of github.com:Expensify/App into beaman-supportNe…

4bab5e3

…wAction-REMOVEDFROMAPPROVALCHAIN

Update translations for multiple submitters

420e152

Remove dupe

423ff6e

Update action type and fix misplaced type

0f6c687

Handle building multiple submitter names

4b091aa

Added semicolon

d0ab84d

Merge branch 'main' of github.com:Expensify/App into beaman-supportNe…

ff3a8f2

…wAction-REMOVEDFROMAPPROVALCHAIN

Add type to destructured param

f7b6c56

Specify type before calling function

5cf7977

prettify

e380ce7

Fix array type and bug

5b9b439

Lint plz be happy

7f4bd94

Beamanator marked this pull request as ready for review September 6, 2024 20:23

Beamanator requested a review from a team as a code owner September 6, 2024 20:23

melvin-bot bot requested a review from stitesExpensify September 6, 2024 20:24

melvin-bot bot removed the request for review from a team September 6, 2024 20:24

stitesExpensify approved these changes Sep 9, 2024

View reviewed changes

stitesExpensify requested a review from allroundexperts September 9, 2024 19:51

Merge branch 'main' of github.com:Expensify/App into beaman-supportNe…

359f1f1

…wAction-REMOVEDFROMAPPROVALCHAIN

allroundexperts approved these changes Sep 10, 2024

View reviewed changes

melvin-bot bot requested a review from carlosmiceli September 10, 2024 23:01

melvin-bot bot mentioned this pull request Sep 10, 2024

Payment issue for E/App PR#48508 #48948

Closed

stitesExpensify merged commit 5224d91 into main Sep 10, 2024
15 checks passed

stitesExpensify deleted the beaman-supportNewAction-REMOVEDFROMAPPROVALCHAIN branch September 10, 2024 23:25

github-actions bot mentioned this pull request Sep 11, 2024

Deploy Checklist: New Expensify 2024-09-11 #48954

Closed

58 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support new action `REMOVED_FROM_APPROVAL_CHAIN` #48508

Support new action `REMOVED_FROM_APPROVAL_CHAIN` #48508

Beamanator commented Sep 3, 2024 •

edited

Loading

melvin-bot bot commented Sep 6, 2024

Beamanator commented Sep 7, 2024

stitesExpensify left a comment

allroundexperts commented Sep 9, 2024 •

edited

Loading

allroundexperts commented Sep 9, 2024

Beamanator commented Sep 9, 2024

Beamanator commented Sep 10, 2024

allroundexperts commented Sep 10, 2024

allroundexperts left a comment

melvin-bot bot commented Sep 10, 2024

melvin-bot bot commented Sep 10, 2024

OSBotify commented Sep 10, 2024

Beamanator commented Sep 11, 2024

Beamanator commented Sep 12, 2024

allroundexperts commented Sep 12, 2024

Support new action REMOVED_FROM_APPROVAL_CHAIN #48508

Support new action REMOVED_FROM_APPROVAL_CHAIN #48508

Conversation

Beamanator commented Sep 3, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 6, 2024

Beamanator commented Sep 7, 2024

stitesExpensify left a comment

Choose a reason for hiding this comment

allroundexperts commented Sep 9, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts commented Sep 9, 2024

Beamanator commented Sep 9, 2024

Beamanator commented Sep 10, 2024

allroundexperts commented Sep 10, 2024

allroundexperts left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Sep 10, 2024

melvin-bot bot commented Sep 10, 2024

OSBotify commented Sep 10, 2024

Beamanator commented Sep 11, 2024

Beamanator commented Sep 12, 2024

allroundexperts commented Sep 12, 2024

Support new action `REMOVED_FROM_APPROVAL_CHAIN` #48508

Support new action `REMOVED_FROM_APPROVAL_CHAIN` #48508

Beamanator commented Sep 3, 2024 •

edited

Loading

allroundexperts commented Sep 9, 2024 •

edited

Loading