Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search v2.3] [App] Implement Saved Search feature #48566

Merged
merged 109 commits into from
Sep 13, 2024
Merged

[Search v2.3] [App] Implement Saved Search feature #48566

merged 109 commits into from
Sep 13, 2024

Commits on Aug 26, 2024

  1. WIP

    @lakchote
    lakchote committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    6598982 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. wip

    @lakchote
    lakchote committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    8da87e9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into lucien/wip-searchv3

    @lakchote
    lakchote committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    fd83f2a View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. add onyx key for NVP SAVED_SEARCHES

    @lakchote
    lakchote committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    6391ba4 View commit details
    Browse the repository at this point in the history

  2. add saved search route

    @lakchote
    lakchote committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    24ff124 View commit details
    Browse the repository at this point in the history

  3. add saved search screens

    @lakchote
    lakchote committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    ef22393 View commit details
    Browse the repository at this point in the history

  4. add Onyx types

    @lakchote
    lakchote committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    3fe4654 View commit details
    Browse the repository at this point in the history

  5. add saved search navigators

    @lakchote
    lakchote committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    1783ff7 View commit details
    Browse the repository at this point in the history

  6. add saved search params and screens

    @lakchote
    lakchote committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    beb323a View commit details
    Browse the repository at this point in the history

  7. add utils for saved search

    @lakchote
    lakchote committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    e9fa985 View commit details
    Browse the repository at this point in the history

  8. add delete saved search

    @lakchote
    lakchote committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    644e4ab View commit details
    Browse the repository at this point in the history

  9. add delete saved search hook

    @lakchote
    lakchote committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    763c985 View commit details
    Browse the repository at this point in the history

  10. fix lint

    @lakchote
    lakchote committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    53bd9c7 View commit details
    Browse the repository at this point in the history

  11. fix lint

    @lakchote
    lakchote committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    a99b9ae View commit details
    Browse the repository at this point in the history

  12. handle cancel button

    @lakchote
    lakchote committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    86e8ed2 View commit details
    Browse the repository at this point in the history

  13. modify component for mobile functionality for saved search

    @lakchote
    lakchote committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    5086308 View commit details
    Browse the repository at this point in the history

  14. saved search rename page

    @lakchote
    lakchote committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    bfa7c2e View commit details
    Browse the repository at this point in the history

  15. add translation

    @lakchote
    lakchote committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    24c50e2 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. add star icon

    @lakchote
    lakchote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    a60778e View commit details
    Browse the repository at this point in the history

  2. add missing properties from MenuItem

    @lakchote
    lakchote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    966c1b8 View commit details
    Browse the repository at this point in the history

  3. fix popover menu not closing

    @lakchote
    lakchote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    a21b7f7 View commit details
    Browse the repository at this point in the history

  4. fix default query string

    @lakchote
    lakchote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    c8b3d4a View commit details
    Browse the repository at this point in the history

  5. fix renaming for default query string to get the same hash

    @lakchote
    lakchote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    3a9daaf View commit details
    Browse the repository at this point in the history

  6. fix popover menu not closing

    @lakchote
    lakchote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    637bb6f View commit details
    Browse the repository at this point in the history

  7. add green color and background related styles

    @lakchote
    lakchote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    8250b36 View commit details
    Browse the repository at this point in the history

  8. fix tooltip display

    @lakchote
    lakchote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    c5fe7a8 View commit details
    Browse the repository at this point in the history

  9. fix lint and prettier

    @lakchote
    lakchote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    b2161a0 View commit details
    Browse the repository at this point in the history

  10. add missing translation key

    @lakchote
    lakchote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    eb283ee View commit details
    Browse the repository at this point in the history

  11. fix tooltip rendering

    @lakchote
    lakchote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    2c28b51 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'main' into lucien/search-savedSearches

    @lakchote
    lakchote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    14204f3 View commit details
    Browse the repository at this point in the history

  13. fix old code relics

    @lakchote
    lakchote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    6a77450 View commit details
    Browse the repository at this point in the history

  14. improve code using canned query

    @lakchote
    lakchote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    182e361 View commit details
    Browse the repository at this point in the history

  15. fix prettier

    @lakchote
    lakchote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    4f4bb07 View commit details
    Browse the repository at this point in the history

  16. fix lint

    @lakchote
    lakchote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    574a584 View commit details
    Browse the repository at this point in the history

  17. fix cancel button not showing on mobile

    @lakchote
    lakchote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    aff30f0 View commit details
    Browse the repository at this point in the history

  18. fix lint

    @lakchote
    lakchote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    0faec36 View commit details
    Browse the repository at this point in the history

  19. fix form for saved search rename page

    @lakchote
    lakchote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    bd4861f View commit details
    Browse the repository at this point in the history

  20. fix typecheck

    @lakchote
    lakchote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    01c9e96 View commit details
    Browse the repository at this point in the history

  21. fix prettier

    @lakchote
    lakchote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    869e21c View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. fix react compiler errors

    @lakchote
    lakchote committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    8767a59 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into lucien/search-savedSearches

    @lakchote
    lakchote committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    363b574 View commit details
    Browse the repository at this point in the history

  3. improve form

    @lakchote
    lakchote committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    446265a View commit details
    Browse the repository at this point in the history

  4. add distinct name

    @lakchote
    lakchote committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    cebf87d View commit details
    Browse the repository at this point in the history

  5. fix cancel button showing everytime

    @lakchote
    lakchote committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    6776ef3 View commit details
    Browse the repository at this point in the history

  6. remove unnecessary params

    @lakchote
    lakchote committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    69c1f2a View commit details
    Browse the repository at this point in the history

  7. remove default value to be consistent with figma file

    @lakchote
    lakchote committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    5b090db View commit details
    Browse the repository at this point in the history

  8. fix bug

    @lakchote
    lakchote committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    82fcd1e View commit details
    Browse the repository at this point in the history

  9. fix lint

    @lakchote
    lakchote committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    29aebb6 View commit details
    Browse the repository at this point in the history

  10. fix lint

    @lakchote
    lakchote committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    08feb86 View commit details
    Browse the repository at this point in the history

  11. fix tsc

    @lakchote
    lakchote committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    dfdcd24 View commit details
    Browse the repository at this point in the history

  12. fix spanish translation

    @lakchote
    lakchote committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    48b45a5 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Merge branch 'main' into lucien/search-savedSearches

    @lakchote
    lakchote committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    bf97c8f View commit details
    Browse the repository at this point in the history

  2. remove blank line

    @lakchote
    lakchote committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    0bd6855 View commit details
    Browse the repository at this point in the history

  3. add the bookmark icon

    @lakchote
    lakchote committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    b54d83c View commit details
    Browse the repository at this point in the history

  4. use the bookmark icon

    @lakchote
    lakchote committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    0f2d5e4 View commit details
    Browse the repository at this point in the history

  5. make saved searches scrollable

    @lakchote
    lakchote committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    422e393 View commit details
    Browse the repository at this point in the history

  6. base64 encode for date

    @lakchote
    lakchote committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    06870b0 View commit details
    Browse the repository at this point in the history

  7. fix accessing saved searches

    @lakchote
    lakchote committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    15760ea View commit details
    Browse the repository at this point in the history

  8. fix style

    @lakchote
    lakchote committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    1273d62 View commit details
    Browse the repository at this point in the history

  9. show save search only if there are filters

    @lakchote
    lakchote committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    4e0a193 View commit details
    Browse the repository at this point in the history

  10. fix style

    @lakchote
    lakchote committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    83640a6 View commit details
    Browse the repository at this point in the history

  11. add to central pane

    @lakchote
    lakchote committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    06acfd9 View commit details
    Browse the repository at this point in the history

  12. revert unneeded base64

    @lakchote
    lakchote committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    1d486e3 View commit details
    Browse the repository at this point in the history

  13. remove useless query string replacement

    @lakchote
    lakchote committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    7819448 View commit details
    Browse the repository at this point in the history

  14. remove draft value

    @lakchote
    lakchote committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    f85e084 View commit details
    Browse the repository at this point in the history

  15. fix cancel button display

    @lakchote
    lakchote committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    aacab14 View commit details
    Browse the repository at this point in the history

  16. fix renaming on iOS

    @lakchote
    lakchote committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    dc97d03 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Merge branch 'main' into lucien/search-savedSearches

    @lakchote
    lakchote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b3d24f6 View commit details
    Browse the repository at this point in the history

  2. add fragment

    @lakchote
    lakchote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    676028c View commit details
    Browse the repository at this point in the history

  3. fix icon name

    @lakchote
    lakchote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8bc0790 View commit details
    Browse the repository at this point in the history

  4. fix tooltip rendering

    @lakchote
    lakchote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    5aed67c View commit details
    Browse the repository at this point in the history

  5. fix style

    @lakchote
    lakchote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6b80a66 View commit details
    Browse the repository at this point in the history

  6. highlight saved search

    @lakchote
    lakchote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    fde60a4 View commit details
    Browse the repository at this point in the history

  7. add onyx util for save search

    @lakchote
    lakchote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    9a1b74a View commit details
    Browse the repository at this point in the history

  8. fix onyx type

    @lakchote
    lakchote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    cd927b8 View commit details
    Browse the repository at this point in the history

  9. fix dependencies

    @lakchote
    lakchote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    377d289 View commit details
    Browse the repository at this point in the history

  10. fix tooltip rendering for renaming a saved search

    @lakchote
    lakchote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    1bdb6bb View commit details
    Browse the repository at this point in the history

  11. fix type check

    @lakchote
    lakchote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    0160485 View commit details
    Browse the repository at this point in the history

  12. fix react compiler error

    @lakchote
    lakchote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    de41f4c View commit details
    Browse the repository at this point in the history

  13. fix icon

    @lakchote
    lakchote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a6a973e View commit details
    Browse the repository at this point in the history

  14. Merge branch 'main' into lucien/search-savedSearches

    @lakchote
    lakchote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    0ed79b6 View commit details
    Browse the repository at this point in the history

  15. remove doublon icon

    @lakchote
    lakchote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    7767de6 View commit details
    Browse the repository at this point in the history

  16. fix type check

    @lakchote
    lakchote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    0da08e9 View commit details
    Browse the repository at this point in the history

  17. fix typo

    @lakchote
    lakchote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    f452a9c View commit details
    Browse the repository at this point in the history

  18. fix delete modal not showing on iOS

    @lakchote
    lakchote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    938133b View commit details
    Browse the repository at this point in the history

  19. fix lint

    @lakchote
    lakchote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a6b791e View commit details
    Browse the repository at this point in the history

  20. fix style

    @lakchote
    lakchote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    215bb66 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Merge branch 'main' into lucien/search-savedSearches

    @lakchote
    lakchote committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    9c7ceea View commit details
    Browse the repository at this point in the history

  2. fix prettier

    @lakchote
    lakchote committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    0fc1098 View commit details
    Browse the repository at this point in the history

  3. fix saved searches display

    @lakchote
    lakchote committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5351e5a View commit details
    Browse the repository at this point in the history

  4. remove onyx code for saved searches (will be done in polish phase)

    @lakchote
    lakchote committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    f897ab4 View commit details
    Browse the repository at this point in the history

  5. fix condition

    @lakchote
    lakchote committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    36936b6 View commit details
    Browse the repository at this point in the history

  6. make the popover menu scrollable

    @lakchote
    lakchote committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    c04e7a1 View commit details
    Browse the repository at this point in the history

  7. fix item highlight with saved search

    @lakchote
    lakchote committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    4acd1cc View commit details
    Browse the repository at this point in the history

  8. hide save search if no filters

    @lakchote
    lakchote committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    6e91abd View commit details
    Browse the repository at this point in the history

  9. fix style

    @lakchote
    lakchote committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a157b36 View commit details
    Browse the repository at this point in the history

  10. reset filters when clicking on saved search

    @lakchote
    lakchote committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    2170426 View commit details
    Browse the repository at this point in the history

  11. fix console warning

    @lakchote
    lakchote committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    77488c1 View commit details
    Browse the repository at this point in the history

  12. fix lint

    @lakchote
    lakchote committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a3f2b23 View commit details
    Browse the repository at this point in the history

  13. proper naming for onyx key

    @lakchote
    lakchote committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    0231886 View commit details
    Browse the repository at this point in the history

  14. use translation

    @lakchote
    lakchote committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    30d7a1d View commit details
    Browse the repository at this point in the history

  15. use proper naming

    @lakchote
    lakchote committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    fa5a70f View commit details
    Browse the repository at this point in the history

  16. fix style

    @lakchote
    lakchote committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    393664f View commit details
    Browse the repository at this point in the history

  17. fix default queryJSON

    @lakchote
    lakchote committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    8b4f4e0 View commit details
    Browse the repository at this point in the history

  18. improve code

    @lakchote
    lakchote committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    2dc08e9 View commit details
    Browse the repository at this point in the history

  19. Merge branch 'main' into lucien/search-savedSearches

    @lakchote
    lakchote committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    afaa391 View commit details
    Browse the repository at this point in the history

  20. fix react compiler

    @lakchote
    lakchote committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    0b2b8f0 View commit details
    Browse the repository at this point in the history

  21. remove unneeded condition

    @lakchote
    lakchote committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    2f7162d View commit details
    Browse the repository at this point in the history

  22. fix lint

    @lakchote
    lakchote committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b076f54 View commit details
    Browse the repository at this point in the history