-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Users with an external domain are displayed as Hidden #48681
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid-app-2024-09-09_11.59.24.mp4Android: mWeb Chromeandroid-chrome-2024-09-09_11.12.57.mp4iOS: Nativeios-app-2024-09-09_12.35.11.mp4iOS: mWeb Safariios-safari-2024-09-09_12.40.19.mp4MacOS: Chrome / Safaridesktop-chrome-2024-09-09_11.01.42.mp4MacOS: Desktopdesktop-app-2024-09-09_11.08.21.mp4 |
NAB: test steps could be a little clearer. Can we remove |
@jjcoffee i updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
@kavimuru We agreed here to fix a specific FE issue, hence the modified testing steps here. I don't have access to applause but I assume what you're seeing is down to a missing BE fix.
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.33-4 🚀
|
Details
Fixed Issues
$ #48464
PROPOSAL: #48464 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android-mweb.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios-mweb.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov