-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Fix Netsuite incorrect credentials crash #48688
[CP Staging] Fix Netsuite incorrect credentials crash #48688
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Thanks. I think this is ready for a reviewer?
Almost! I'm adding a web video to prove it's the correct solution. Here it is: Screen.Recording.2024-09-06.at.11.06.26.mov |
This comment was marked as off-topic.
This comment was marked as off-topic.
FYI @shubham1206agra, builds are in progress |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2024-09-06.at.2.51.28.PM.movAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
@Julesssss I think we can merge it now :) |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…ite-crash Fix Netsuite incorrect credentials crash (cherry picked from commit fd86641) (CP triggered by Julesssss)
Details
Fixed Issues
$ #48682
PROPOSAL: #48682 (comment)
Tests
Can't connect to NetSuite
textOffline tests
QA Steps
Can't connect to NetSuite
textPR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop