-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove free workspace #48700
Remove free workspace #48700
Conversation
Waiting for #45175 (comment) |
8e3d488
to
de3ded4
Compare
In this PR, I removed 4 pages: Card, Travel, Bill, Reimburse. Invoice Page will be reused #45175 (comment) Reimburse.mov |
@situchan Please review this PR |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
@cretadn22 I think we can still have Tests / QA Steps.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Please merge main though.
@situchan Updated the newest main branch |
@cretadn22 please fix conflict |
@situchan It is done |
There's another conflict. I think we can wait until 19th, by when @tgolen is back from OOO |
The ESlint-check failure come from https://expensify.slack.com/archives/C01GTK53T8Q/p1726169039084589. The changes in this PR are significant, so I think we overlook them for now and address them in a future PR. |
@cretadn22 please
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still CONST.POLICY.TYPE.FREE
usage in SidebarFilterTest.ts
@situchan Reply this comment: #48700 (comment) I think we should ask @tgolen about this first because we are also waiting for their reviewing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that ended up being a pretty sizeable cleanup.
I think it's OK to merge this with the ESLint errors. That was not code that is in the scope of this change, nor were you responsible for it. It would be nice to get those deprecated methods removed at some point though, but it should be done in a separate issue. You picked up a conflict. |
@tgolen I resolved all problems |
@tgolen Is there any problem? |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/tgolen in version: 9.0.40-0 🚀
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.40-6 🚀
|
Details
Fixed Issues
$ #48345
PROPOSAL: #48345 (comment)
Tests
Offline tests
QA Steps
No Need
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop