[CP Staging] Fix useResponsiveLayout bugs #48723

rayane-djouah · 2024-09-06T15:19:33Z

cc @getusha

Details

This fixes bugs caused by #46788

Fixed Issues

$ #48675
$ #48724

Tests

Precondition: Workspace is connected to QBO, or have multi tags set up.
Go to staging.new.expensify.com
Go to workspace settings > Tags.
Click on any main tag.
Click Select all checkbox.
Expected Result: App will not freeze.

Test 2:

Go to staging.new.expensify.com
Go to workspace settings > Report fields
Click Add field
Select List from Type field
Click List values
Click Add value
Add some list values
Expected Result: There will be checkbox next to each list value

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-09-06.at.4.49.01.PM.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-09-06.at.17.01.49.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-09-06.at.16.29.04.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-09-06.at.4.23.52.PM.mov

MacOS: Desktop

Screen.Recording.2024-09-06.at.4.29.25.PM.mov

melvin-bot · 2024-09-06T15:30:18Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rayane-djouah · 2024-09-06T15:39:41Z

@eh2077 Sorry for the ping, @getusha will review this one

rayane-djouah · 2024-09-06T16:37:23Z

#48724 is also fixed

Beamanator · 2024-09-06T16:47:41Z

Looks like this fixes regressions caused by #46788, eh?

Beamanator · 2024-09-06T17:08:44Z

Report Fields fix working well on Chrome & Desktop 👍

Screen.Recording.2024-09-06.at.11.03.04.AM.mov

Screen.Recording.2024-09-06.at.11.07.53.AM.mov

src/components/SelectionListWithModal/index.tsx

Beamanator

Code looks good!

getusha · 2024-09-06T18:46:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-06.at.11.33.28.at.night.mov

Android: mWeb Chrome

Screen.Recording.2024-09-06.at.10.53.48.at.night.mov

iOS: Native

Screen.Recording.2024-09-06.at.10.38.12.at.night.mov

iOS: mWeb Safari

Screen.Recording.2024-09-06.at.10.47.59.at.night.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-06.at.10.21.27.at.night.mov

MacOS: Desktop

Screen.Recording.2024-09-06.at.10.55.30.at.night.mov

github-actions · 2024-09-06T18:56:53Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/48723/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/48723/NewExpensify.dmg	https://48723.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

… have unique ReleaseAsset.name

…order to have unique ReleaseAsset.name" This reverts commit cce4b4d.

Beamanator

LGTM

OSBotify · 2024-09-07T00:46:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Beamanator · 2024-09-07T02:00:36Z

This should get CP'd on Monday 🙏

…cking-checkbox-in-subtag-list [CP Staging] Fix useResponsiveLayout bugs (cherry picked from commit a9dc596) (CP triggered by roryabraham)

Beamanator · 2024-09-09T14:45:26Z

This was CP'd last Friday - https://github.com/Expensify/App/actions/runs/10748576364 - failed in Desktop build but made it on a subsequent CP

Fix - App freezes when clicking checkbox in subtag list

6979c15

rayane-djouah changed the title ~~Fix - App freezes when clicking checkbox in subtag list~~ [CP Staging] Fix - App freezes when clicking checkbox in subtag list Sep 6, 2024

rayane-djouah marked this pull request as ready for review September 6, 2024 15:30

rayane-djouah requested a review from a team as a code owner September 6, 2024 15:30

melvin-bot bot requested review from eh2077 and removed request for a team September 6, 2024 15:30

rayane-djouah mentioned this pull request Sep 6, 2024

Multi tags - App freezes when clicking checkbox in subtag list #48675

Closed

6 tasks

Fix - Report fields - No checkbox next to list value on web layout

60f9fcc

rayane-djouah changed the title ~~[CP Staging] Fix - App freezes when clicking checkbox in subtag list~~ [CP Staging] Fix useResponsiveLayout bugs Sep 6, 2024

rayane-djouah mentioned this pull request Sep 6, 2024

[$0] Report fields - No checkbox next to list value on web layout #48724

Closed

6 tasks

rayane-djouah marked this pull request as draft September 6, 2024 16:33

rayane-djouah marked this pull request as ready for review September 6, 2024 16:33

Beamanator requested review from getusha and removed request for eh2077 September 6, 2024 16:47

Beamanator reviewed Sep 6, 2024

View reviewed changes

src/components/SelectionListWithModal/index.tsx Outdated Show resolved Hide resolved

Clarify comments

71489bb

rayane-djouah requested a review from Beamanator September 6, 2024 17:57

Beamanator reviewed Sep 6, 2024

View reviewed changes

src/components/SelectionListWithModal/index.tsx Outdated Show resolved Hide resolved

Beamanator added the Ready To Build label Sep 6, 2024

Clarify comments

6bd40e0

rayane-djouah requested a review from Beamanator September 6, 2024 18:29

Beamanator previously approved these changes Sep 6, 2024

View reviewed changes

Rename web and desktop sourcemaps artifacts before upload in order to…

cce4b4d

… have unique ReleaseAsset.name

rayane-djouah dismissed Beamanator’s stale review via cce4b4d September 6, 2024 19:20

Revert "Rename web and desktop sourcemaps artifacts before upload in …

26b28ec

…order to have unique ReleaseAsset.name" This reverts commit cce4b4d.

getusha approved these changes Sep 6, 2024

View reviewed changes

melvin-bot bot requested a review from Beamanator September 6, 2024 20:36

Beamanator approved these changes Sep 7, 2024

View reviewed changes

Beamanator merged commit a9dc596 into Expensify:main Sep 7, 2024
16 checks passed

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Sep 7, 2024

ikevin127 mentioned this pull request Sep 7, 2024

[Awaiting Payment] [$250] Multi tags - Main tag shows "Required" status when all the subtags are disabled #48683

Closed

6 tasks

rayane-djouah deleted the Fix-App-freezes-when-clicking-checkbox-in-subtag-list branch September 7, 2024 13:26

ikevin127 mentioned this pull request Sep 7, 2024

Main tag shows Required status when all subtags are disabled #48738

Merged

50 tasks

rayane-djouah mentioned this pull request Sep 11, 2024

[HOLD for payment 2024-10-30] [$1000] Create a useResponsiveLayout hook #30528

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Fix useResponsiveLayout bugs #48723

[CP Staging] Fix useResponsiveLayout bugs #48723

rayane-djouah commented Sep 6, 2024 •

edited

Loading

melvin-bot bot commented Sep 6, 2024

rayane-djouah commented Sep 6, 2024

rayane-djouah commented Sep 6, 2024 •

edited

Loading

Beamanator commented Sep 6, 2024

Beamanator commented Sep 6, 2024

Beamanator left a comment

getusha commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024

Beamanator left a comment

OSBotify commented Sep 7, 2024

Beamanator commented Sep 7, 2024

Beamanator commented Sep 9, 2024

[CP Staging] Fix useResponsiveLayout bugs #48723

[CP Staging] Fix useResponsiveLayout bugs #48723

Conversation

rayane-djouah commented Sep 6, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 6, 2024

rayane-djouah commented Sep 6, 2024

rayane-djouah commented Sep 6, 2024 • edited Loading

Beamanator commented Sep 6, 2024

Beamanator commented Sep 6, 2024

Beamanator left a comment

Choose a reason for hiding this comment

getusha commented Sep 6, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

github-actions bot commented Sep 6, 2024

Beamanator left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 7, 2024

Beamanator commented Sep 7, 2024

Beamanator commented Sep 9, 2024

rayane-djouah commented Sep 6, 2024 •

edited

Loading

rayane-djouah commented Sep 6, 2024 •

edited

Loading

getusha commented Sep 6, 2024 •

edited

Loading