Fix notification preference by defaulting to hidden #48887

shubham1206agra · 2024-09-10T12:22:34Z

Details

In getReportNotificationPreference, we are defaulting to notification preference of hidden since not doing that will cause fantom unread report to show up where we didn't even join the chat. One such example would be public rooms.

I have changed the test since we need to mock Sign In with the user before the test since we uses logged in user account ID to determine the notification preference. And we have fixed some old tests too.

Fixed Issues

$ #46835

Tests

Please see tests from TestRail and verify you don't see any report in LHN where you haven't joined report.

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-09-10T12:22:38Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2024-09-10T15:01:06Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Desktop build failed	The QR code can't be generated, because the web build failed

👀 View the workflow run that generated this build 👀

ishpaul777 · 2024-09-10T17:51:30Z

@puneetlath Could you help test this internally i was not able to reproduce this issue so not able to test it to be sure that it is gone.

ishpaul777 · 2024-09-10T17:51:46Z

@shubham1206agra Jest test failing

ishpaul777 · 2024-09-11T19:56:10Z

tests/unit/SidebarOrderTest.ts

I am very confused for the changes in this file, and most things are not self explantory, please provide summary of changes and how our changes are affecting this tests. I see test 'orders IOU reports by displayName if amounts are the same' is completly removed i am not sure why

Since the test is wrong, and does not make sense now.

please provide summary of changes and how our changes are affecting this tests.

Added the details section.

ishpaul777 · 2024-09-11T19:57:09Z

tests/unit/SidebarOrderTest.ts

-    NETWORK: 'network',
-    IS_LOADING_REPORT_DATA: 'isLoadingReportData',
-} as const;
+jest.mock('@src/hooks/useResponsiveLayout');


Not sure why we need this now, but not before, How our changes affect this

Since I used full Onyx keys from ONYXKEYS file.

i meant that usage of mock '@src/hooks/useResponsiveLayout'

Its just to fix a bug in Rendering SidebarLinks correctly.

how does our change affect this

Since the earlier test was wrong actually. And I need mimic shouldUseNarrowLayout to false to include the hidden IOU report if the active report ID is IOU report ID.

ishpaul777 · 2024-09-11T19:58:56Z

Please add tests from testrail that you have tested for this in PR tests section. and complete videos

ishpaul777 · 2024-09-11T20:04:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-09-12.at.8.04.04.PM-1.mov

MacOS: Desktop

ishpaul777 · 2024-09-12T14:40:38Z

I tested on one of my High traffic account that there are no chats in my LHN, that i am not a member of, so this LGTM!

Screen.Recording.2024-09-12.at.8.04.04.PM-1.mov

…rence Fix notification preference by defaulting to hidden (cherry picked from commit 4d0c30d) (CP triggered by luacmartins)

OSBotify · 2024-09-12T19:43:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-12T20:17:49Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.0.33-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-09-12T21:19:35Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.33-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix notification preference where we should default to hidden

a1e3814

shubham1206agra requested a review from a team as a code owner September 10, 2024 12:22

melvin-bot bot requested a review from ishpaul777 September 10, 2024 12:22

melvin-bot bot removed the request for review from a team September 10, 2024 12:22

shubham1206agra added 2 commits September 10, 2024 18:38

Fix test part 1

f93d13c

Fix test part 2

d8be6e4

puneetlath added the Ready To Build label Sep 10, 2024

This comment has been minimized.

Sign in to view

shubham1206agra added 3 commits September 11, 2024 22:37

Fix jest test part 3

c211680

Fix jest test part 4

c9b41ad

Fix perf test attempt 1

593c33a

ishpaul777 reviewed Sep 11, 2024

View reviewed changes

ishpaul777 approved these changes Sep 12, 2024

View reviewed changes

melvin-bot bot requested a review from puneetlath September 12, 2024 14:41

puneetlath approved these changes Sep 12, 2024

View reviewed changes

puneetlath merged commit 4d0c30d into Expensify:main Sep 12, 2024
17 of 27 checks passed

OSBotify pushed a commit that referenced this pull request Sep 12, 2024

Merge pull request #48887 from shubham1206agra/fix-notification-prefe…

fe8e7d3

…rence Fix notification preference by defaulting to hidden (cherry picked from commit 4d0c30d) (CP triggered by luacmartins)

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Sep 12, 2024

github-actions bot mentioned this pull request Sep 12, 2024

Deploy Checklist: New Expensify 2024-09-11 #49025

Closed

49 tasks

melvin-bot bot mentioned this pull request Sep 12, 2024

[HOLD for payment 2024-09-19][$1000] Replace report.notificationPreference with report.participants #46835

Open

5 tasks

ishpaul777 mentioned this pull request Sep 13, 2024

[HOLD #46835] [CRITICAL] Notification - User received desktop notification for a room a visited but didn't join #35000

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix notification preference by defaulting to hidden #48887

Fix notification preference by defaulting to hidden #48887

shubham1206agra commented Sep 10, 2024 •

edited

Loading

melvin-bot bot commented Sep 10, 2024

This comment has been minimized.

github-actions bot commented Sep 10, 2024

ishpaul777 commented Sep 10, 2024

ishpaul777 commented Sep 10, 2024

ishpaul777 Sep 11, 2024 •

edited

Loading

shubham1206agra Sep 12, 2024

ishpaul777 Sep 12, 2024

shubham1206agra Sep 12, 2024

ishpaul777 Sep 11, 2024

shubham1206agra Sep 12, 2024

ishpaul777 Sep 12, 2024

shubham1206agra Sep 12, 2024

ishpaul777 Sep 12, 2024

shubham1206agra Sep 12, 2024

ishpaul777 commented Sep 11, 2024 •

edited

Loading

ishpaul777 commented Sep 11, 2024 •

edited

Loading

ishpaul777 commented Sep 12, 2024 •

edited

Loading

OSBotify commented Sep 12, 2024

OSBotify commented Sep 12, 2024

OSBotify commented Sep 12, 2024

Fix notification preference by defaulting to hidden #48887

Fix notification preference by defaulting to hidden #48887

Conversation

shubham1206agra commented Sep 10, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 10, 2024

This comment has been minimized.

github-actions bot commented Sep 10, 2024

ishpaul777 commented Sep 10, 2024

ishpaul777 commented Sep 10, 2024

ishpaul777 Sep 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ishpaul777 commented Sep 11, 2024 • edited Loading

ishpaul777 commented Sep 11, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

ishpaul777 commented Sep 12, 2024 • edited Loading

OSBotify commented Sep 12, 2024

OSBotify commented Sep 12, 2024

OSBotify commented Sep 12, 2024

shubham1206agra commented Sep 10, 2024 •

edited

Loading

ishpaul777 Sep 11, 2024 •

edited

Loading

ishpaul777 commented Sep 11, 2024 •

edited

Loading

ishpaul777 commented Sep 11, 2024 •

edited

Loading

ishpaul777 commented Sep 12, 2024 •

edited

Loading