-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Create a manual workflow for PRs deployment comments #48938
[No QA] Create a manual workflow for PRs deployment comments #48938
Conversation
@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
I suggest we close this in favor of #49563. It's overall pretty similar but doesn't add a workflow only for use in manual cases when something is broken. Instead it creates a callable workflow, uses it in the main Thanks @rayane-djouah for the idea 💡 |
cc @roryabraham @luacmartins
Discussing here: https://expensify.slack.com/archives/C01GTK53T8Q/p1726004633120889?thread_ts=1725898121.666369&cid=C01GTK53T8Q
Details
This PR adds a new manual workflow to comment on PRs that were deployed but the
postGithubComment
job of the deploy workflow failed. Example: https://github.com/Expensify/App/actions/runs/10776607506Fixed Issues
$
PROPOSAL:
Tests
Merge the PR and run the
Manual PRs Deployment Notifier
manual workflow against this production deploy checklist release version: #48664Docs:
https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/manually-running-a-workflow
Inputs:
TAG: 9.0.30-19
Date: 2024-09-09
IS_PRODUCTION_DEPLOY: true
Verify that no errors appear in the JS console
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop