Onyx File handling - preparation #4908
+214
−116
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,6 +53,7 @@ function getImagePickerOptions(type) { | |
| */ | ||
| const documentPickerOptions = { | ||
| type: [RNDocumentPicker.types.allFiles], | ||
| copyTo: 'cachesDirectory', | ||
|
There was a problem hiding this comment. Does android have a cachesDirectory? I only see it for IOS There was a problem hiding this comment. Documentation says:
I take it the option |
||
| }; | ||
|
|
||
| /** | ||
|
|
@@ -66,7 +67,7 @@ function getDataForUpload(fileData) { | |
| const fileResult = { | ||
| name: fileData.fileName || fileData.name || 'chat_attachment', | ||
| type: fileData.type, | ||
| uri: fileData.fileCopyUri || fileData.uri, | ||
|
There was a problem hiding this comment. The document picker makes the attachment available until the application is terminated The |
||
| size: fileData.fileSize || fileData.size, | ||
| }; | ||
|
|
||
|
|
@@ -127,20 +128,22 @@ class AttachmentPicker extends Component { | |
| * Handles the image/document picker result and | ||
| * sends the selected attachment to the caller (parent component) | ||
| * | ||
| * @param {Array<ImagePickerResponse|DocumentPickerResponse>} attachments | ||
| * @returns {Promise} | ||
| */ | ||
| pickAttachment(attachments = []) { | ||
| if (attachments.length === 0) { | ||
| return; | ||
| } | ||
|
|
||
| const fileData = _.first(attachments); | ||
|
|
||
| if (fileData.width === -1 || fileData.height === -1) { | ||
| this.showImageCorruptionAlert(); | ||
| return; | ||
| } | ||
|
|
||
| return getDataForUpload(fileData).then((result) => { | ||
| this.completeAttachmentSelection(result); | ||
| }).catch((error) => { | ||
| this.showGeneralAlert(error.message); | ||
|
|
@@ -196,7 +199,7 @@ class AttachmentPicker extends Component { | |
| } | ||
|
|
||
| // Resolve with the first (and only) selected file | ||
| return resolve(response.assets); | ||
| }); | ||
| }); | ||
| } | ||
|
|
@@ -225,7 +228,7 @@ class AttachmentPicker extends Component { | |
| /** | ||
| * Launch the DocumentPicker. Results are in the same format as ImagePicker | ||
| * | ||
| * @returns {Promise<DocumentPickerResponse[]>} | ||
| */ | ||
| showDocumentPicker() { | ||
| return RNDocumentPicker.pick(documentPickerOptions).catch((error) => { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just not used? Not seeing it in any changes from this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was used here:
src/libs/SignoutManager.jsBut now the file is deleted - no longer necessary
What the
SignoutManagerdid was to synchronize the logout across multiple tabsBut now with
localForagethis is no longer neededWe're touching on this here: Expensify/react-native-onyx#102 (comment)