-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Profile - There is tooltip for Profile Share button but no tooltip for Workspace Share button. #49193
Conversation
…ip for Workspace Share button. Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Expensify/design, please take a look at the screenshots section. Also, I have found an inconsistency between personal profile page and workspace profile page.
Do we also need to align them? inconsistency.mp4 |
@Expensify/design, please check the above comment ^ |
@shawnborton @dannymcclain @dubielzyk-expensify, can you please check this comment? |
Is this related to the issue though? Seems like a bit of an aside, but that being said I don't mind that they're different, but I can also see us using the same value. I'll let the others designers chime in too. @Expensify/design |
No, it's not related to the issue. I noticed an inconsistency, so I thought we could address it here if the design team agrees. |
Yeah I feel exactly the same as Jon. If you want to sneak this in here and make them consistent, then that sounds good to me. |
I also feel the same as Jon and Shawn. I do think it'd be nice for them to be consistent. And I'd probably opt to make them both |
Awesome. Yeah let's go for 24px like Danny suggested. Thanks for calling out the inconsistency and helping us fix it 👍 |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Done! @c3024, you can start reviewing :) |
Reviewer Checklist
Screenshots/VideosAndroid: NativetooltipAndroid.mp4Android: mWeb ChrometooltipAndroidmWeb.mp4iOS: NativetooltipiOS.mp4iOS: mWeb SafaritooltipiOSmWeb.mp4MacOS: Chrome / SafaritooltipChrome.mp4MacOS: DesktoptooltipDesktop.mp4 |
I think QA Test steps like the following will be clearer for QA team and also test all changes made:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.40-0 🚀
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.40-6 🚀
|
Details
Fixed Issues
$ #48418
PROPOSAL: #48418 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android_native.mp4
Android: mWeb Chrome
android_chrome.mp4
iOS: Native
ios_native.mp4
iOS: mWeb Safari
ios_safari.mp4
MacOS: Chrome / Safari
web_chrome.mp4
MacOS: Desktop
desktop_app.mp4