-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update beginningOfChatHistory with fresh copy #47427 #49209
base: main
Are you sure you want to change the base?
Update beginningOfChatHistory with fresh copy #47427 #49209
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA. |
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
♻️ I started working on the checklist. @mariapeever In the meantime please make sure to add screenshots or videos for all platforms as this is a blocker for the PR because of the checklist:
Another blocker for this PR is the fact that while english languace copy was changed, I noticed that the spanish translations were not updated, as per this checklist item:
Meaning for all english copy that was changed, we need to also translate and change the spanish version of the same variables - to do this, as mentioned in the checklist: you need to post in #expensify-open-source Slack channel and request translations for the new english copy and provide some context on the request like link to the issue. |
Regarding ^ this, I asked in slack for somebody to help w/ spanish translations: https://expensify.slack.com/archives/C01GTK53T8Q/p1726624473137749 @mariapeever
Important Same issue with changing the description happens in the following cases as well: workspace #announce and #admins rooms, so they should be fixed / tested there as well.
|
@ikevin127 I have resolved the issues and updated the PR. Just waiting for a Spanish translation. |
Just got the verified spanish translations:
@mariapeever Important When testhing this, please compare PR / Staging side by side for all 9 copy cases and also for regular and workspace linked chats which also have the workspace archived version once a workspace is deleted. I would suggest looking at the current staging code and applying the changes to simply change the copy and not the logic because currently it feels like we're drifting away more and more from current Staging with each change and we're getting more issues. Here's a summary after the latest changes (3 commits):
Workspace admins - Displaying #[roomName] instead of [workspaceName]
Workspace announce - Displaying #[roomName] instead of [workspaceName]
Workspace archived - Missing [submitter]
Workspace announce archived - Missing [submitter]
Workspace room archived - Crashing the app when opened |
@ikevin127 I have made the adjustments and added the Spanish translation. |
Unfortunately, as I mentioned before we're drifting away more and more from current staging with each change and we're getting more issues with each new commit. Here are a few PR / Staging screenshots to showcase most of the current issues (and there are more): ScreenshotsWorkspace - #admins
Workspace - #announce
Workspace - #admins (archived)
Workspace - #announce (archived)
Workspace (archived)
Workspace - Member Chat (archived)
Invoice room
Invoice room (archived)
I have to take some accountability here for assignment and admit that I did not think this issue / PR will be as complex as it is in terms of code changes and now it's becoming clear to me that I did not take in consideration the codebase familiarity when I assigned you given that this is your very first contribution. Given that it's been over 1 week since the PR was opened and we're not even close to merge and also some of the feedback I provided in the IMPORTANT notes above was not taken in consideration - I discussed with the team and decided that given the timeline of the issue, we're going to re-assign this to the contributor next in line given they have more experience with the codebase. cc @mariapeever |
@ikevin127 I haven't seen your last message - I was just working on the PR with the screenshots until today. I don't think this makes sense now considering the time I have spent to submit the updates. You probably thought it could take longer. I have re-tested everything and it works. |
Details
Fixed Issues
$ #47427
PROPOSAL: #47427
Tests
Offline tests
Tests as above - no changes
QA Steps
As above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop