Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix approve report partially shows wrong owes amount in LHN #49279

Merged
merged 7 commits into from
Sep 19, 2024
Merged

Fix approve report partially shows wrong owes amount in LHN #49279

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3bd0049
fix approve report partially shows wrong owes amount
bernhardoj Sep 16, 2024
f19136f
optimistically update the iou report total
bernhardoj Sep 16, 2024
e48b744
add missing param
bernhardoj Sep 16, 2024
d526f4a
Merge branch 'main' into fix/48760-wrong-expense-total-when-approve-p…
bernhardoj Sep 18, 2024
fa37921
calc the total amount from the transactions
bernhardoj Sep 18, 2024
3897b39
Merge branch 'main' into fix/48760-wrong-expense-total-when-approve-p…
bernhardoj Sep 19, 2024
e5ad3d6
revert extra changes
bernhardoj Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/actions/IOU.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6448,7 +6448,7 @@ function getReportFromHoldRequestsOnyxData(
chatReport.reportID,
chatReport.policyID ?? iouReport.policyID ?? '',
recipient.accountID ?? 1,
(firstHoldTransaction?.amount ?? 0) * -1,
holdTransactions.reduce((acc, transaction) => acc + transaction.amount, 0) * -1,
getCurrency(firstHoldTransaction),
false,
newParentReportActionID,
Expand Down
Loading