Use float instead of int for auditRate percentage. Fix incorrect params in `SetPolicyAutoReimbursementLimitParams` #49320

marcaaron · 2024-09-17T00:45:47Z

Details

Holding on:

Fixed Issues

$ #49254

Tests

Create a new workspace
Go to workspace settings
Enable Rules + Upgrade
Enable Workflows + Go to Workflows
Enable "Add approvals"
Go to Rules
Enable "Auto-approve compliant reports" and "Auto-pay approved reports"
Verify the amount for "Auto-pay reports under" is 100.
Verify the amount for "Auto-approve reports under" is 100
Verify Random report audit percentage is 5
Disable "Auto-approve compliant reports" and "Auto-pay approved reports"
Reenable "Auto-approve compliant reports" and "Auto-pay approved reports"
Verify the same amounts as before.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

No / wasn't able to get this build to work for some reason

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

marcaaron · 2024-09-25T19:22:55Z

This is coming off HOLD now. I will do the final testing and open for reviews.

github-actions · 2024-09-25T20:00:57Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/49320/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/49320/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/49320/NewExpensify.dmg	https://49320.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

melvin-bot · 2024-09-26T00:11:53Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2024-09-26T09:45:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-26.at.16.57.24.mov

Android: mWeb Chrome

Screen.Recording.2024-09-26.at.16.49.42.mov

iOS: Native

Screen.Recording.2024-09-26.at.16.53.23.mov

iOS: mWeb Safari

Screen.Recording.2024-09-26.at.16.47.10.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-26.at.16.44.47.mov

MacOS: Desktop

Screen.Recording.2024-09-26.at.16.46.18.mov

DylanDylann · 2024-09-26T10:04:53Z

@marcaaron Also please help to add ?. when accessing to pendingFields from policy?.fieldList?.[CONST.POLICY.FIELDS.FIELD_LIST_TITLE]

App/src/pages/workspace/rules/ExpenseReportRulesSection.tsx

Line 66 in b930641

    
           !policy?.pendingFields?.shouldShowCustomReportTitleOption && policy?.fieldList?.[CONST.POLICY.FIELDS.FIELD_LIST_TITLE].pendingFields?.defaultValue

App/src/pages/workspace/rules/ExpenseReportRulesSection.tsx

Line 67 in b930641

    
           ? policy?.fieldList?.[CONST.POLICY.FIELDS.FIELD_LIST_TITLE].pendingFields?.defaultValue

App/src/pages/workspace/rules/ExpenseReportRulesSection.tsx

Line 82 in b930641

    
           !policy?.pendingFields?.shouldShowCustomReportTitleOption && policy?.fieldList?.[CONST.POLICY.FIELDS.FIELD_LIST_TITLE].pendingFields?.deletable

App/src/pages/workspace/rules/ExpenseReportRulesSection.tsx

Line 83 in b930641

    
           ? policy?.fieldList?.[CONST.POLICY.FIELDS.FIELD_LIST_TITLE].pendingFields?.deletable

This isn't related to our PR, but I see a problem on Android while testing this PR (note that: I could only reproduce this bug one time, I tried again but can't reproduce it anymore)

Screen.Recording.2024-09-26.at.16.54.27.mov

DylanDylann

Everything else looks good to me

melvin-bot · 2024-09-26T10:05:54Z

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

srikarparsi · 2024-09-26T19:21:36Z

Hey @marcaaron, do you want to handle this in this PR or should I review as is?

marcaaron · 2024-09-26T20:13:20Z

Yes thanks! I made those changes.

github-actions · 2024-09-27T17:59:05Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.0.41-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-09-30T22:40:52Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.41-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Use float instead of int for auditRate percentage

f5d39d8

marcaaron self-assigned this Sep 17, 2024

marcaaron added 2 commits September 16, 2024 16:08

Simplify logic for autoReimbursement

054221c

Fix the params for SetPolicyAutoReimbursementLimit as they are incorrect

f527d62

marcaaron changed the title ~~[WIP] Use float instead of int for auditRate percentage~~ [WIP] Use float instead of int for auditRate percentage. Fix incorrect params in SetPolicyAutoReimbursementLimitParams Sep 18, 2024

marcaaron changed the title ~~[WIP] Use float instead of int for auditRate percentage. Fix incorrect params in SetPolicyAutoReimbursementLimitParams~~ [HOLD] Use float instead of int for auditRate percentage. Fix incorrect params in SetPolicyAutoReimbursementLimitParams Sep 18, 2024

marcaaron added 2 commits September 17, 2024 17:33

Merge branch 'main' into marcaaron-setDefaultAuditRate

99ebc63

Merge branch 'main' into marcaaron-setDefaultAuditRate

7d1126f

marcaaron changed the title ~~[HOLD] Use float instead of int for auditRate percentage. Fix incorrect params in SetPolicyAutoReimbursementLimitParams~~ Use float instead of int for auditRate percentage. Fix incorrect params in SetPolicyAutoReimbursementLimitParams Sep 25, 2024

marcaaron added the Ready To Build label Sep 25, 2024

marcaaron marked this pull request as ready for review September 26, 2024 00:11

marcaaron requested a review from a team as a code owner September 26, 2024 00:11

melvin-bot bot requested review from DylanDylann and removed request for a team September 26, 2024 00:11

DylanDylann approved these changes Sep 26, 2024

View reviewed changes

melvin-bot bot requested a review from srikarparsi September 26, 2024 10:05

Fix expected missing field in ExpenseReportRulesSection

6f58877

srikarparsi approved these changes Sep 26, 2024

View reviewed changes

srikarparsi merged commit 70a8a16 into main Sep 26, 2024
16 checks passed

srikarparsi deleted the marcaaron-setDefaultAuditRate branch September 26, 2024 21:15

marcaaron mentioned this pull request Sep 26, 2024

[$250] Rules - Unable to clear default value and save value in Random report audit field #49742

Closed

6 tasks

github-actions bot mentioned this pull request Sep 27, 2024

Deploy Checklist: New Expensify 2024-09-27 #49855

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use float instead of int for auditRate percentage. Fix incorrect params in `SetPolicyAutoReimbursementLimitParams` #49320

Use float instead of int for auditRate percentage. Fix incorrect params in `SetPolicyAutoReimbursementLimitParams` #49320

marcaaron commented Sep 17, 2024 •

edited

Loading

marcaaron commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

melvin-bot bot commented Sep 26, 2024

DylanDylann commented Sep 26, 2024 •

edited

Loading

DylanDylann commented Sep 26, 2024 •

edited

Loading

DylanDylann left a comment

melvin-bot bot commented Sep 26, 2024

srikarparsi commented Sep 26, 2024

marcaaron commented Sep 26, 2024

github-actions bot commented Sep 27, 2024

github-actions bot commented Sep 30, 2024

Use float instead of int for auditRate percentage. Fix incorrect params in SetPolicyAutoReimbursementLimitParams #49320

Use float instead of int for auditRate percentage. Fix incorrect params in SetPolicyAutoReimbursementLimitParams #49320

Conversation

marcaaron commented Sep 17, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

marcaaron commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

melvin-bot bot commented Sep 26, 2024

DylanDylann commented Sep 26, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

DylanDylann commented Sep 26, 2024 • edited Loading

DylanDylann left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Sep 26, 2024

srikarparsi commented Sep 26, 2024

marcaaron commented Sep 26, 2024

github-actions bot commented Sep 27, 2024

github-actions bot commented Sep 30, 2024

Use float instead of int for auditRate percentage. Fix incorrect params in `SetPolicyAutoReimbursementLimitParams` #49320

Use float instead of int for auditRate percentage. Fix incorrect params in `SetPolicyAutoReimbursementLimitParams` #49320

marcaaron commented Sep 17, 2024 •

edited

Loading

DylanDylann commented Sep 26, 2024 •

edited

Loading

DylanDylann commented Sep 26, 2024 •

edited

Loading