fix last accessed report for new user #49324

c3024 · 2024-09-17T06:21:14Z

Details

The lastAccessedReport returns the first found non-Concierge report in reports array. This PR fixes it to get correct last accessed report.

Fixed Issues

$ #48840
PROPOSAL: #48840 (comment)

Tests

Login with a new email.
Select "Manage my team's expenses" option in the onboarding modal.
Fill "Where do you work?" and then "What's your name?" and "Continue".
Go to Concierge chat.
Scroll down (if necessary) to get to the "Setup categories" task.
Click on this task to get to the task report.
Find the "Take me to workspace category settings" link and click on it.
On the Categories page opened, click on back arrow in the left hand panel.
Click on "Inbox" now.
Verify that you are now navigated to the task report at step 6.

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Login with a new email.
Select "Manage my team's expenses" option in the onboarding modal.
Fill "Where do you work?" and then "What's your name?" and "Continue".
Go to Concierge chat.
Scroll down (if necessary) to get to the "Setup categories" task.
Click on this task to get to the task report.
Find the "Take me to workspace category settings" link and click on it.
On the Categories page opened, click on back arrow in the left hand panel.
Click on "Inbox" now.
Verify that you are now navigated to the task report at step 6.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

lastAndroid.mp4

Android: mWeb Chrome

lastAndroidmWeb.mp4

iOS: Native

lastiOS.mp4

iOS: mWeb Safari

lastiOSmWeb.mp4

MacOS: Chrome / Safari

lastChrome.mp4

MacOS: Desktop

lastDesktop.mp4

melvin-bot · 2024-09-17T06:21:22Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jayeshmangwani · 2024-09-17T16:04:02Z

@c3024 Could you please complete the checklist and add the missing platform's video?

c3024 · 2024-09-18T11:31:22Z

I am testing them. Will soon upload.

ESLint checks are failing but those failures are not related to changes in this PR.

Was there any change in how these checks are made?

jayeshmangwani · 2024-09-18T11:33:59Z

Was there any change in how these checks are made?

Yes recently we made a lint rule that if we edit any file that uses the deprecated code then it will throw lint error

c3024 · 2024-09-18T15:17:35Z

@jayeshmangwani

Uploaded all videos.

Fixed the lint errors with removing getParentReportAction from ReportUtils.

Code was just refactored to remove the originalMessage lint error because we use originalMessage in building all optimistic report actions in this file. Completely removing originalMessage fields in all buildOptimisticXReportAction function should be separately handled in a different issue IMO.

Tested a few basic cases for these changes generally.

testParentChrome.mp4

Please have a look.

c3024 · 2024-09-18T15:20:29Z

src/libs/ReportUtils.ts

-        html: ReportActionsUtils.getReportActionHtml(reportAction.reportAction),
-        taskReportID: ReportActionsUtils.getReportActionMessage(reportAction.reportAction)?.taskReportID,
-        whisperedTo: [],
+    reportAction.reportAction = {


reportAction.originalMessage throws a lint error. We use originalMessage in building all optimistic report actions in this file. So, just refactored to remove that error.

@c3024 We have a PR #49325 addressing the linting of the src/libs/ReportUtils.ts file. What do you think about waiting for the other PR before proceeding?

Commented on that PR. Wish I checked that before.

Wish I checked that before

That happens sometimes 😃

c3024 · 2024-09-20T04:59:29Z

That PR fixing ReportUtils ESLint issues was merged into main.

I pulled main and fixed the conflicts.

Let's go!

jayeshmangwani · 2024-09-20T05:21:55Z

Great, starting review now!

jayeshmangwani · 2024-09-20T06:46:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

iOS.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

jayeshmangwani

Changed works well, LGTM 🚀

OSBotify · 2024-09-20T15:19:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-24T19:29:50Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 9.0.40-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-09-27T17:44:45Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.40-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix last accessed report for new user

a5c93ee

c3024 requested a review from a team as a code owner September 17, 2024 06:21

melvin-bot bot requested review from jayeshmangwani and removed request for a team September 17, 2024 06:21

c3024 added 2 commits September 18, 2024 20:02

remove deprecated getParentReportAction

ee02e42

refactor to avoid lint

f365b4e

remove unnecessary comment

8684bd8

c3024 commented Sep 18, 2024

View reviewed changes

c3024 mentioned this pull request Sep 19, 2024

Fix ReportUtils Lint #49325

Merged

50 tasks

Merge branch 'main' into correct-last-accessed-report-for-new-user

c561af8

jayeshmangwani approved these changes Sep 20, 2024

View reviewed changes

melvin-bot bot requested a review from bondydaa September 20, 2024 06:52

bondydaa approved these changes Sep 20, 2024

View reviewed changes

bondydaa merged commit ee7cdad into Expensify:main Sep 20, 2024
17 checks passed

daledah mentioned this pull request Sep 22, 2024

fix: return to chat when leave thread #48970

Closed

50 tasks

ishpaul777 mentioned this pull request Sep 23, 2024

[Awaiting Payment] [$250] Thread – Your space opens when leave thread in a new non-validated account #48550

Closed

6 tasks

github-actions bot mentioned this pull request Sep 24, 2024

Deploy Checklist: New Expensify 2024-09-24 #49662

Closed

67 tasks

bondydaa mentioned this pull request Sep 30, 2024

Payment due 2024-10-04 [$250] When navigate to Workspace Editor then back to Inbox, it is taking me to my self DM rather than last chat #48840

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix last accessed report for new user #49324

fix last accessed report for new user #49324

c3024 commented Sep 17, 2024 •

edited

Loading

melvin-bot bot commented Sep 17, 2024

jayeshmangwani commented Sep 17, 2024

c3024 commented Sep 18, 2024

jayeshmangwani commented Sep 18, 2024 •

edited

Loading

c3024 commented Sep 18, 2024

c3024 Sep 18, 2024

jayeshmangwani Sep 19, 2024

c3024 Sep 19, 2024

jayeshmangwani Sep 19, 2024

c3024 commented Sep 20, 2024

jayeshmangwani commented Sep 20, 2024

jayeshmangwani commented Sep 20, 2024 •

edited

Loading

jayeshmangwani left a comment

OSBotify commented Sep 20, 2024

OSBotify commented Sep 24, 2024

github-actions bot commented Sep 27, 2024

fix last accessed report for new user #49324

fix last accessed report for new user #49324

Conversation

c3024 commented Sep 17, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 17, 2024

jayeshmangwani commented Sep 17, 2024

c3024 commented Sep 18, 2024

jayeshmangwani commented Sep 18, 2024 • edited Loading

c3024 commented Sep 18, 2024

c3024 Sep 18, 2024

Choose a reason for hiding this comment

jayeshmangwani Sep 19, 2024

Choose a reason for hiding this comment

c3024 Sep 19, 2024

Choose a reason for hiding this comment

jayeshmangwani Sep 19, 2024

Choose a reason for hiding this comment

c3024 commented Sep 20, 2024

jayeshmangwani commented Sep 20, 2024

jayeshmangwani commented Sep 20, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

jayeshmangwani left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 20, 2024

OSBotify commented Sep 24, 2024

github-actions bot commented Sep 27, 2024

c3024 commented Sep 17, 2024 •

edited

Loading

jayeshmangwani commented Sep 18, 2024 •

edited

Loading

jayeshmangwani commented Sep 20, 2024 •

edited

Loading