-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error spacing inconsistency fixed #49398
Conversation
@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
I am getting this error in ESLint that is not related to my PR.
Am I supposed to migrate it from Idk if someone else might be working on the migration of this component. |
If it is in main, hopefully it will be resolved soon and we can pull main to this branch and resolve this issue |
PR is ready for review |
@alitoshmatov bump for review |
@alitoshmatov All tests are passed. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb Chromelength-android.moviOS: Nativelength-ios.mp4iOS: mWeb Safarilength-safari.mp4MacOS: Chrome / Safarilength-web.movMacOS: Desktoplength-desktop.mov |
Sorry took longer to review than usual |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/francoisl in version: 9.0.41-0 🚀
|
Details
Spacing in error message in Fields for Expensify Page are not consistent
Fixed Issues
$ #48659
PROPOSAL: #48659 (comment)
Tests
Offline tests
There are no offline tests as you cannot switch to expensify classic offline.
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-09-20.at.10.07.11.PM.mov
Android: mWeb Chrome
Screen.Recording.2024-09-20.at.6.09.33.PM.mov
iOS: Native
Screen.Recording.2024-09-18.at.6.44.34.PM.mov
iOS: mWeb Safari
Screen.Recording.2024-09-18.at.1.12.04.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2024-09-18.at.12.25.56.PM.mov
MacOS: Desktop
Screen.Recording.2024-09-18.at.12.33.59.PM.mov