-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid suggestion box calculation on firs input focus #49589
Avoid suggestion box calculation on firs input focus #49589
Conversation
The error says |
@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add platform screenshots
ahh, sorry about that, added |
…fix-suggestion-list-appear-on-input-initial-focus
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.mp4Android: mWeb ChromeiOS: Nativeios1.movios2.moviOS: mWeb SafariMacOS: Chrome / Safariweb.movMacOS: Desktop |
Please merge main (1.5k commits behind) |
We did not find an internal engineer to review this PR, trying to assign a random engineer to #47661 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
@perunt kind bump #49589 (comment) |
…fix-suggestion-list-appear-on-input-initial-focus
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/Gonals in version: 9.0.45-1 🚀
|
We reverted this PR to fix #50283 cc: @perunt @mkhutornyi |
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.45-4 🚀
|
Details
Fixed Issues
$ #47661
PROPOSAL: #47661 (comment)
Tests
You can also use all test cases described in this PR #44113
Offline tests
QA Steps
Launch app
Tap fab -- start chat -- room
Create a room
Enter @jaihanumanblig@gmail.com
Send the message
In a whisper message, tap invite
Long press the message sent in step 4, and select edit comment
No suggestion box shouldn't appear when the input is focused first time
Open any chat
Open the emoji picker menu
Select a skin tone (other than the default yellow)
Verify that the hand emoji has the proper selected color
Close and reopen the app
Open any chat
Open the emoji picker menu
Verify that the hand emoji still has the previously selected color
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen_Recording_20240923_113742_New.Expensify.Dev.mp4
Android: mWeb Chrome
2024-09-24.11.46.18.mp4
iOS: Native
RPReplay_Final1727167209.MP4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-24.at.11.37.42.mp4
MacOS: Chrome / Safari
Untitled.mov
MacOS: Desktop
Untitled.mov