Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Update remaining e.cash usages w/ New Expensify #4968

Merged
merged 2 commits into from
Sep 1, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion desktop/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ mc mb electron-builder/electron-builder
6. Verify that the new bucket has been created by navigating to https://localhost:9000/minio/electron-builder in your browser and confriming you see an interface like this:
![electron-builder](https://user-images.githubusercontent.com/3981102/120376267-8842d700-c2d0-11eb-86cb-f595f27d535d.png)

7. Set your testing bucket to be public, which will allow the e.cash dmg access the local latest-mac.yml file we'll be publishing
7. Set your testing bucket to be public, which will allow the NewExpensify.dmg access the local latest-mac.yml file we'll be publishing
```
mc policy set public electron-builder/electron-builder
```
Expand Down
2 changes: 1 addition & 1 deletion src/App.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const App = () => (
]}
>
<CustomStatusBar />
<ErrorBoundary errorMessage="E.cash crash caught by error boundary">
<ErrorBoundary errorMessage="NewExpensify crash caught by error boundary">
<Expensify />
</ErrorBoundary>
</ComposeProviders>
Expand Down
2 changes: 1 addition & 1 deletion src/libs/actions/BankAccounts.js
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ function fetchFreePlanVerifiedBankAccount(stepToOpen) {
: CONST.BANK_ACCOUNT.STEP.BANK_ACCOUNT;

// @TODO Again, not sure how much of this logic is needed right now
// as we shouldn't be handling any open accounts in E.cash yet that need to pass any more
// as we shouldn't be handling any open accounts in New Expensify yet that need to pass any more
// checks or can be upgraded, but leaving in for possible future compatibility.
if (bankAccount.isOpen()) {
if (bankAccount.needsToPassLatestChecks()) {
Expand Down
2 changes: 1 addition & 1 deletion src/libs/actions/Report.js
Original file line number Diff line number Diff line change
Expand Up @@ -750,7 +750,7 @@ function subscribeToUserEvents() {

/**
* There are 2 possibilities that we can receive via pusher for a user's typing status:
* 1. The "new" way from e.cash is passed as {[login]: Boolean} (e.g. {yuwen@expensify.com: true}), where the value
* 1. The "new" way from New Expensify is passed as {[login]: Boolean} (e.g. {yuwen@expensify.com: true}), where the value
* is whether the user with that login is typing on the report or not.
* 2. The "old" way from e.com which is passed as {userLogin: login} (e.g. {userLogin: bstites@expensify.com})
*
Expand Down
2 changes: 1 addition & 1 deletion src/pages/signin/SignInPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ class SignInPage extends Component {

// Show the password form if
// - A login has been entered
// - AND a GitHub username has been entered OR they already have access to expensify cash
// - AND a GitHub username has been entered OR they already have access to New Expensify
// - AND an account exists and is validated for this login
// - AND a password hasn't been entered yet
const showPasswordForm = this.props.credentials.login
Expand Down