-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix initial chat switch jarring #49731
Fix initial chat switch jarring #49731
Conversation
Still some ongoing design discussion going on in the issue thread, will review when that's concluded. |
Asked for some confirmation on further design changes. |
@perunt We have merge conflicts if you could take a look, thanks. |
@perunt 👀 on the merge conflicts plz |
…into @perunt/fix-initial-chat-switch-jarring
…fix-initial-chat-switch-jarring
Reviewer Checklist
Screenshots/VideosAndroid: Native01_Android_Native.mp4Android: mWeb Chrome02_Android_Chrome.mp4iOS: Native03_iOS_Native.mp4iOS: mWeb Safari04_iOS_Safari.mp4MacOS: Chrome / Safari05_MacOS_Chrome.mp4MacOS: Desktop06_MacOS_Desktop.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
We did not find an internal engineer to review this PR, trying to assign a random engineer to #48762 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.57-0 🚀
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.57-10 🚀
|
Details
The initial issue was removing the jarring effect when you open a report from the LHN that you haven't opened yet (not cached)
Fixed Issues
$ #48762
PROPOSAL:
Tests
a. An empty page initially
b. Then a skeleton loading state
c. Finally, the updated data
During this entire process, the composer and the header should remain in the same place. When the skeleton appears, you should see the correct user data in the header and the composer.
Note: To clear reports from the cache, you can log out and then log back in.
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Untitled.2.mov
MacOS: Desktop