Don't apply failure data for 460 jsonCode #49759

roryabraham · 2024-09-25T23:21:57Z

Details

For Expensify, a 460 jsonCode means "admin required". In other words, the user is trying to use an API command to modify a policy when they are not an admin of that policy.

Fixed Issues

$ #49753
PROPOSAL: https://expensify.slack.com/archives/C01GTK53T8Q/p1727303751986769?thread_ts=1727300442.697579&cid=C01GTK53T8Q

Tests / QA Steps

Sign into NewDot with an account that's going to be the policy owner. Let's call this user Alice.
Create a workspace
As Alice, go to Settings -> Workspaces -> <workspace> -> Members, and invite a new admin to the policy. Let's call this user Bob.
Sign in as Bob.
Open the workspace settings page
Go offline
Change a workspace setting. I've been testing with Add Approvals, but most Policy settings should work.
As Alice, go to Settings -> Workspaces -> <workspace> -> Members, and change Bob's status from Admin to Member.
As Bob, come back online.
Verify that you see a 404 not found page
Verify that when you navigate back to Settings -> Workspaces -> <workspace>, you do not see a red dot next to the workspace.

Verify that no errors appear in the JS console

Offline tests

included in test/QA steps

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

iOS: Native

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

roryabraham · 2024-09-26T01:23:20Z

finishing up screenshots but we can open this up for C+ review

melvin-bot · 2024-09-26T01:23:55Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2024-09-26T02:03:54Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/49759/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/49759/NewExpensify.dmg	https://49759.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

ishpaul777 · 2024-09-26T13:16:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

WhatsApp.Video.2024-09-26.at.10.58.31.PM.mp4

Android: mWeb Chrome

WhatsApp.Video.2024-09-26.at.10.41.47.PM.mp4

iOS: Native

Screen.Recording.2024-09-26.at.7.22.53.PM.mov

iOS: mWeb Safari

ScreenRecording_09-26-2024.18-52-12_1.MP4

MacOS: Chrome / Safari

Screen.Recording.2024-09-26.at.6.35.42.PM.mov

MacOS: Desktop

Screen.Recording.2024-09-26.at.10.46.14.PM.mov

ishpaul777 · 2024-09-26T13:26:59Z

Bug?: On mweb i have this Empty RBR when admin role is changed to member

ScreenRecording_09-26-2024.18-52-12_1.MP4

Something similar with with IOS on workspace list page

Screen.Recording.2024-09-26.at.7.22.53.PM.mov

roryabraham · 2024-09-26T16:59:37Z

@ishpaul777 that looks like it might be a separate 🐛

Or maybe, we need to update the back-end to return a 460 in that case.

ishpaul777 · 2024-09-26T17:25:44Z

okay, one small concern i am not sure if its possible in app or not, but have we thought about the case when failuredata is applied to reset the isloading values to false if we never apply failure data it might just stuck at true, hence the loading indicator may show infinitely

roryabraham · 2024-09-26T17:28:27Z

good point @ishpaul777. Discussed in slack and I think if it does come up, we can just move the loading state cleanup from failureData to finallyData, which will always be applied after.

ishpaul777

LGTM!

melvin-bot · 2024-09-26T17:42:35Z

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

grgia · 2024-09-27T12:27:03Z

src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

-        let bankDisplayName = bankName ?? addressName;
-        if (accountNumber && bankDisplayName !== accountNumber) {
-            bankDisplayName += ` ${accountNumber.slice(-5)}`;
-        }


what is this change for?

bankDisplayName is unused variable

Yeah, sorry just doing some scope-creep cleanup of unused code

grgia

LGTM

OSBotify · 2024-09-27T20:01:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-09-30T22:57:46Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.0.42-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-02T00:20:38Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.42-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

roryabraham added 2 commits September 25, 2024 16:04

Don't apply failureData if we receive a 460 response

6c42779

Add a comment explaining 460 errors

0fa776a

roryabraham self-assigned this Sep 25, 2024

roryabraham added the Ready To Build label Sep 26, 2024

roryabraham marked this pull request as ready for review September 26, 2024 01:23

roryabraham requested a review from a team as a code owner September 26, 2024 01:23

melvin-bot bot requested review from ishpaul777 and removed request for a team September 26, 2024 01:23

ishpaul777 approved these changes Sep 26, 2024

View reviewed changes

melvin-bot bot requested a review from grgia September 26, 2024 17:42

grgia reviewed Sep 27, 2024

View reviewed changes

grgia approved these changes Sep 27, 2024

View reviewed changes

roryabraham merged commit b6b559d into main Sep 27, 2024
21 of 28 checks passed

roryabraham deleted the Rory-NoFailureDataFor460 branch September 27, 2024 19:51

github-actions bot mentioned this pull request Sep 30, 2024

Deploy Checklist: New Expensify 2024-09-30 #49960

Closed

49 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't apply failure data for 460 jsonCode #49759

Don't apply failure data for 460 jsonCode #49759

roryabraham commented Sep 25, 2024 •

edited

Loading

roryabraham commented Sep 26, 2024

melvin-bot bot commented Sep 26, 2024

github-actions bot commented Sep 26, 2024

ishpaul777 commented Sep 26, 2024 •

edited

Loading

ishpaul777 commented Sep 26, 2024 •

edited

Loading

roryabraham commented Sep 26, 2024

ishpaul777 commented Sep 26, 2024

roryabraham commented Sep 26, 2024 •

edited

Loading

ishpaul777 left a comment

melvin-bot bot commented Sep 26, 2024

grgia Sep 27, 2024

ishpaul777 Sep 27, 2024

roryabraham Sep 27, 2024

grgia left a comment

OSBotify commented Sep 27, 2024

github-actions bot commented Sep 30, 2024

github-actions bot commented Oct 2, 2024

Don't apply failure data for 460 jsonCode #49759

Don't apply failure data for 460 jsonCode #49759

Conversation

roryabraham commented Sep 25, 2024 • edited Loading

Details

Fixed Issues

Tests / QA Steps

Offline tests

PR Author Checklist

Screenshots/Videos

roryabraham commented Sep 26, 2024

melvin-bot bot commented Sep 26, 2024

github-actions bot commented Sep 26, 2024

ishpaul777 commented Sep 26, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

ishpaul777 commented Sep 26, 2024 • edited Loading

roryabraham commented Sep 26, 2024

ishpaul777 commented Sep 26, 2024

roryabraham commented Sep 26, 2024 • edited Loading

ishpaul777 left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Sep 26, 2024

grgia Sep 27, 2024

Choose a reason for hiding this comment

ishpaul777 Sep 27, 2024

Choose a reason for hiding this comment

roryabraham Sep 27, 2024

Choose a reason for hiding this comment

grgia left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 27, 2024

github-actions bot commented Sep 30, 2024

github-actions bot commented Oct 2, 2024

roryabraham commented Sep 25, 2024 •

edited

Loading

ishpaul777 commented Sep 26, 2024 •

edited

Loading

ishpaul777 commented Sep 26, 2024 •

edited

Loading

roryabraham commented Sep 26, 2024 •

edited

Loading