-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Fix style change #49760
Conversation
Added @rushatgabhane as reviewer since he reviewed the original PR #48876 (comment) |
I think @rushatgabhane may be offline, @akinwale are you around to review this? |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-09-26.at.1.01.29.AM.movAndroid: mWeb ChromeScreen.Recording.2024-09-26.at.1.03.21.AM.moviOS: NativeSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-09-26.at.00.59.11.mp4iOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-09-26.at.00.57.43.mp4MacOS: Chrome / SafariScreen.Recording.2024-09-26.at.12.55.56.AM.movMacOS: DesktopScreen.Recording.2024-09-26.at.12.58.08.AM.mov |
Asked for a C+ here: https://expensify.slack.com/archives/C02NK2DQWUX/p1727307477011559, @rayane-djouah offered to help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well
@neil-marcellini Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Do we need the |
From looking at other cp'd PRs it seems to be automatic |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP Staging] Fix style change (cherry picked from commit de984f7) (CP triggered by AndrewGable)
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.0.40-3 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.40-6 🚀
|
Details
Style was changed here
, not sure why yet: #48876 (comment)Removing the
View
seems to fix the issueFixed Issues
$ #49749
PROPOSAL: #49749 (comment)
Tests
X selected
should be full width.Offline tests
QA Steps
X selected
should be full width.PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
The 3-vertical-dot button is not cut on the right side in desktop:
MacOS: Desktop