Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Ping deployers when mobile prod deploys fail #4980

Merged
merged 2 commits into from
Sep 1, 2021

Conversation

roryabraham
Copy link
Contributor

Details

Ping mobile-deployers in #deployer when mobile prod deploys fail.

Fixed Issues

$ #4955

Tests

Not 100% sure how to test this. Maybe the following:

  1. Merge this PR
  2. Retry this production deploy
  3. When iOS prod deploy fails, verify that we post in slack with the given message.

Two potential issues with this testing plan I see:

  1. In step 2, I think it might use the previous version of the GH workflow code and not the code including this PR.
  2. It doesn't test Android (although that might be fine)

QA Steps

None.

@roryabraham roryabraham self-assigned this Sep 1, 2021
@roryabraham roryabraham requested a review from a team as a code owner September 1, 2021 05:06
@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team September 1, 2021 05:07
jasperhuangg
jasperhuangg previously approved these changes Sep 1, 2021
@roryabraham
Copy link
Contributor Author

Updated to include link to stores

@AndrewGable AndrewGable merged commit 8c60189 into main Sep 1, 2021
@AndrewGable AndrewGable deleted the Rory-PingDeployerWhenMobileDeployFails branch September 1, 2021 20:37
@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@roryabraham
Copy link
Contributor Author

roryabraham commented Sep 2, 2021

This change did not take effect in the latest iOS prod deploy (which failed), so need to remember to re-check in the next failed mobile deploy.

@OSBotify
Copy link
Contributor

OSBotify commented Sep 2, 2021

🚀 Deployed to staging by @AndrewGable in version: 1.0.91-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Sep 3, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.92-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants