Fix - Attachment - Unable to download a txt attachment until the browser is refreshed #49898
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,8 +2,7 @@ import {Str} from 'expensify-common'; | |
| import React, {memo, useContext, useEffect, useState} from 'react'; | ||
| import type {GestureResponderEvent, StyleProp, ViewStyle} from 'react-native'; | ||
| import {View} from 'react-native'; | ||
| import {useOnyx} from 'react-native-onyx'; | ||
| import AttachmentCarouselPagerContext from '@components/Attachments/AttachmentCarousel/Pager/AttachmentCarouselPagerContext'; | ||
| import type {Attachment, AttachmentSource} from '@components/Attachments/types'; | ||
| import DistanceEReceipt from '@components/DistanceEReceipt'; | ||
|
|
@@ -24,60 +23,57 @@ import * as TransactionUtils from '@libs/TransactionUtils'; | |
| import type {ColorValue} from '@styles/utils/types'; | ||
| import variables from '@styles/variables'; | ||
| import ONYXKEYS from '@src/ONYXKEYS'; | ||
| import AttachmentViewImage from './AttachmentViewImage'; | ||
| import AttachmentViewPdf from './AttachmentViewPdf'; | ||
| import AttachmentViewVideo from './AttachmentViewVideo'; | ||
| import DefaultAttachmentView from './DefaultAttachmentView'; | ||
| import HighResolutionInfo from './HighResolutionInfo'; | ||
|
|
||
| type AttachmentViewProps = Attachment & { | ||
| /** Whether this view is the active screen */ | ||
| isFocused?: boolean; | ||
|
|
||
| /** Function for handle on press */ | ||
| onPress?: (e?: GestureResponderEvent | KeyboardEvent) => void; | ||
|
|
||
| isUsedInAttachmentModal?: boolean; | ||
|
|
||
| /** Flag to show/hide download icon */ | ||
| shouldShowDownloadIcon?: boolean; | ||
|
|
||
| /** Flag to show the loading indicator */ | ||
| shouldShowLoadingSpinnerIcon?: boolean; | ||
|
|
||
| /** Notify parent that the UI should be modified to accommodate keyboard */ | ||
| onToggleKeyboard?: (shouldFadeOut: boolean) => void; | ||
|
|
||
| /** A callback when the PDF fails to load */ | ||
| onPDFLoadError?: () => void; | ||
|
|
||
| /** Extra styles to pass to View wrapper */ | ||
| containerStyles?: StyleProp<ViewStyle>; | ||
|
|
||
| /** Denotes whether it is a workspace avatar or not */ | ||
| isWorkspaceAvatar?: boolean; | ||
|
|
||
| /** Denotes whether it is an icon (ex: SVG) */ | ||
| maybeIcon?: boolean; | ||
|
|
||
| /** Fallback source to use in case of error */ | ||
| fallbackSource?: AttachmentSource; | ||
|
|
||
| /* Whether it is hovered or not */ | ||
| isHovered?: boolean; | ||
|
|
||
| /** Whether the attachment is used as a chat attachment */ | ||
| isUsedAsChatAttachment?: boolean; | ||
|
|
||
| /* Flag indicating whether the attachment has been uploaded. */ | ||
| isUploaded?: boolean; | ||
|
|
||
| /** Flag indicating if the attachment is being uploaded. */ | ||
| isUploading?: boolean; | ||
| }; | ||
|
|
||
| function AttachmentView({ | ||
| source, | ||
|
|
@@ -95,16 +91,20 @@ function AttachmentView({ | |
| isWorkspaceAvatar, | ||
| maybeIcon, | ||
| fallbackSource, | ||
| transactionID = '-1', | ||
|
There was a problem hiding this comment. There is a conversation about the usage of In the future I understand we want undefined or null (not sure which one), so I don't know if we should be using There was a problem hiding this comment. We will continue with |
||
| reportActionID, | ||
| isHovered, | ||
| duration, | ||
| isUsedAsChatAttachment, | ||
| isUploaded = true, | ||
| isUploading = false, | ||
| }: AttachmentViewProps) { | ||
| const {translate} = useLocalize(); | ||
| const {updateCurrentlyPlayingURL} = usePlaybackContext(); | ||
| const attachmentCarouselPagerContext = useContext(AttachmentCarouselPagerContext); | ||
|
|
||
| const [transaction] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`); | ||
|
|
||
| const theme = useTheme(); | ||
| const styles = useThemeStyles(); | ||
| const StyleUtils = useStyleUtils(); | ||
|
|
@@ -288,20 +288,16 @@ function AttachmentView({ | |
| <DefaultAttachmentView | ||
| fileName={file?.name} | ||
| shouldShowDownloadIcon={shouldShowDownloadIcon} | ||
| // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing | ||
| shouldShowLoadingSpinnerIcon={shouldShowLoadingSpinnerIcon || isUploading} | ||
| containerStyles={containerStyles} | ||
| isUploading={isUploading} | ||
| /> | ||
| ); | ||
| } | ||
|
|
||
| AttachmentView.displayName = 'AttachmentView'; | ||
|
|
||
| export default memo(AttachmentView); | ||
|
|
||
| export type {AttachmentViewProps}; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we missed to add a comment to this prop when it was added, could we add it please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.