-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added README.md, and unified deployment to both Preview and Production CF environments. #49906
Conversation
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Your New Help changes have been deployed to https://13b99cc2.newhelp.pages.dev ⚡️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there supposed to be a theme working? I see just plain text for both the preview page and production https://13b99cc2.newhelp.pages.dev/ https://newhelp.expensify.com
* `gem install jekyll bundler` | ||
7. Create a branch for your changes | ||
8. Make your changes | ||
9. Locally build and test your changes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're missing a step before 9 to run bundle install
which installs the gems from the Gemfile via bundler.
If you are a developer comfortable working on the command line, you can edit these files as follows: | ||
|
||
1. Fork https://github.com/Expensify/App repo | ||
* `...tbd...` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you going to fill this before merging?
### The easy way: edit on Github | ||
If you don't want to set up your own local dev environment, feel free to just edit the help materials directly from Github: | ||
|
||
1. ... give instructions here ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question here, are you going to fill this?
@justinpersaud No, there is no theme; just HTML. It's very much an in-development situation right now and I'm just testing the deploy process. |
@coleaeason The README is a WIP, just verifying that I was able to create the file without accidentally publishing it on the site itself. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/quinthar in version: 9.0.42-0 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.42-3 🚀
|
Fixed Issues
$https://github.com/Expensify/Expensify/issues/414789
Tests
Offline tests
n/a
QA Steps
n/a
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
n/a