[NoQA] fix: add retry builds #49925

kirillzyusko · 2024-09-30T12:53:43Z

Details

Added retry mechanism to apk build step.

Fixed Issues

$ #49924
PROPOSAL: N/A

Tests

Verify that no random failures happens when building apk file.

Offline tests

N/A

QA Steps

N/A

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-09-30T12:53:48Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

akinwale · 2024-09-30T14:48:37Z

@kirillzyusko What's the build APK command to test this?

kirillzyusko · 2024-09-30T15:22:46Z

@akinwale I believe it's impossible to test locally.

I tested in fork by modifying e2e build pipeline, but it's a pretty complicated approach as I had to change quite a lot of files.

But you can see all changes that I made (reverted) in this commit: 00dc1fd

akinwale · 2024-10-01T12:08:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

akinwale

LGTM.

melvin-bot · 2024-10-01T12:08:29Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #49924 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

arosiclair · 2024-10-01T14:00:10Z

.github/actions/composite/buildAndroidE2EAPK/action.yml

+      with:
+        retry_on: error
+        retry_wait_seconds: 60
+        timeout_minutes: 60


I don't have much context, but this seems like a very long timeout. How long do the builds usually take?

30-45 minutes

Alright makes sense 👍

arosiclair · 2024-10-03T15:15:44Z

Have we done this yet?

mountiny · 2024-10-07T14:23:22Z

@kirillzyusko @arosiclair What are the next steps on this one? can you sync main and merge this in case its all good?

kirillzyusko · 2024-10-08T13:16:05Z

@mountiny I rebased to the latest main. Would you mind to trigger a new build to verify that everything works and we don't break anything?

mountiny · 2024-10-08T14:09:13Z

Running the e2e tests from this branch to confirm all works fine https://github.com/Expensify/App/actions/runs/11237255476

kirillzyusko · 2024-10-09T07:47:09Z

Running the e2e tests from this branch to confirm all works fine https://github.com/Expensify/App/actions/runs/11237255476

The build stage has passed 👀

mountiny

Thanks! @arosiclair can you please have a look and merge if everything looks fine? Thank you

melvin-bot · 2024-10-09T13:48:07Z

@arosiclair looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2024-10-09T13:58:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

mountiny · 2024-10-09T18:24:13Z

Not emergency, as the failing action seems to be flaky

github-actions · 2024-10-09T20:47:17Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.0.47-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-10T23:02:28Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.47-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kirillzyusko requested a review from a team as a code owner September 30, 2024 12:53

melvin-bot bot requested a review from akinwale September 30, 2024 12:53

melvin-bot bot removed the request for review from a team September 30, 2024 12:53

kirillzyusko mentioned this pull request Sep 30, 2024

E2E Testing: PRs merged after a regression all get marked as regression as well #48085

Open

akinwale approved these changes Oct 1, 2024

View reviewed changes

melvin-bot bot requested a review from arosiclair October 1, 2024 12:10

arosiclair reviewed Oct 1, 2024

View reviewed changes

mountiny assigned kirillzyusko Oct 2, 2024

kirillzyusko added 3 commits October 8, 2024 15:00

test

5232524

fix: revert changes necessary for testing

40c0073

fix: post rebase changes

a84a99d

kirillzyusko force-pushed the fix/add-retry-builds branch from 00dc1fd to a84a99d Compare October 8, 2024 13:13

mountiny approved these changes Oct 9, 2024

View reviewed changes

arosiclair approved these changes Oct 9, 2024

View reviewed changes

arosiclair merged commit 8e53105 into Expensify:main Oct 9, 2024
13 of 14 checks passed

melvin-bot bot added the Emergency label Oct 9, 2024

arosiclair removed the Emergency label Oct 9, 2024

github-actions bot mentioned this pull request Oct 9, 2024

Deploy Checklist: New Expensify 2024-10-09 #50518

Closed

58 tasks

melvin-bot bot mentioned this pull request Oct 10, 2024

[HOLD for payment 2024-10-17] Rare build failures during apk assembling #49924

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NoQA] fix: add retry builds #49925

[NoQA] fix: add retry builds #49925

kirillzyusko commented Sep 30, 2024

melvin-bot bot commented Sep 30, 2024

akinwale commented Sep 30, 2024

kirillzyusko commented Sep 30, 2024

akinwale commented Oct 1, 2024

akinwale left a comment

melvin-bot bot commented Oct 1, 2024

arosiclair Oct 1, 2024

hannojg Oct 2, 2024

arosiclair Oct 3, 2024

arosiclair commented Oct 3, 2024

mountiny commented Oct 7, 2024

kirillzyusko commented Oct 8, 2024

mountiny commented Oct 8, 2024

kirillzyusko commented Oct 9, 2024

mountiny left a comment

melvin-bot bot commented Oct 9, 2024

OSBotify commented Oct 9, 2024

mountiny commented Oct 9, 2024

github-actions bot commented Oct 9, 2024

github-actions bot commented Oct 10, 2024

[NoQA] fix: add retry builds #49925

[NoQA] fix: add retry builds #49925

Conversation

kirillzyusko commented Sep 30, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 30, 2024

akinwale commented Sep 30, 2024

kirillzyusko commented Sep 30, 2024

akinwale commented Oct 1, 2024

Reviewer Checklist

Screenshots/Videos

akinwale left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Oct 1, 2024

arosiclair Oct 1, 2024

Choose a reason for hiding this comment

hannojg Oct 2, 2024

Choose a reason for hiding this comment

arosiclair Oct 3, 2024

Choose a reason for hiding this comment

arosiclair commented Oct 3, 2024

mountiny commented Oct 7, 2024

kirillzyusko commented Oct 8, 2024

mountiny commented Oct 8, 2024

kirillzyusko commented Oct 9, 2024

mountiny left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Oct 9, 2024

OSBotify commented Oct 9, 2024

mountiny commented Oct 9, 2024

github-actions bot commented Oct 9, 2024

github-actions bot commented Oct 10, 2024