Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pasting amount with comma #5024

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

mananjadhav
Copy link
Collaborator

@pecanoro Can you please review this?

Details

  • Updated regex to allow pasting numbers with a comma
  • Strip comma after pasting

Fixed Issues

$ #4885

Tests

  1. Pasted the number with a comma
  2. Ensured that typing doesn't put comma

QA Steps

  1. Try any IOU feature like Split or Request money
  2. Take a number with comma(s)
  3. Paste and see that the number is pasted.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web-amount-comma-paste.mp4

Mobile Web

NA - We don't allow pasting in mobile web

Desktop

desktop-amount-comma-paste.mp4

iOS

NA - We don't allow pasting in iOS

Android

NA - We don't allow pasting in Android

@mananjadhav mananjadhav requested a review from a team as a code owner September 2, 2021 18:57
@MelvinBot MelvinBot requested review from marcaaron and removed request for a team September 2, 2021 18:57
@mananjadhav
Copy link
Collaborator Author

@pecanoro Anything pending in this for merge?

@pecanoro
Copy link
Contributor

pecanoro commented Sep 9, 2021

I was waiting for @marcaaron to review it since he is also assigned as a reviewer.

Copy link
Contributor

@marcaaron marcaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcaaron marcaaron merged commit 5e401d5 into Expensify:main Sep 9, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Sep 9, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Sep 9, 2021

🚀 Deployed to staging by @marcaaron in version: 1.0.95-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Sep 10, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-17. 🎊

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.96-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants