-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow pasting amount with comma #5024
Conversation
@pecanoro Anything pending in this for merge? |
I was waiting for @marcaaron to review it since he is also assigned as a reviewer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @marcaaron in version: 1.0.95-2 🚀
|
This has been deployed to production and is now subject to a 7-day regression period. |
🚀 Deployed to production by @roryabraham in version: 1.0.96-0 🚀
|
@pecanoro Can you please review this?
Details
Fixed Issues
$ #4885
Tests
QA Steps
Tested On
Screenshots
Web
web-amount-comma-paste.mp4
Mobile Web
NA - We don't allow pasting in mobile web
Desktop
desktop-amount-comma-paste.mp4
iOS
NA - We don't allow pasting in iOS
Android
NA - We don't allow pasting in Android