Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] perf: Resolve issues with long Android builds #50240

Merged
merged 4 commits into from
Oct 9, 2024
Merged

[No QA] perf: Resolve issues with long Android builds #50240

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12a6363
get react native version once in build.gradle
TMisiukiewicz Oct 4, 2024
f0ba29b
reduce diff
TMisiukiewicz Oct 4, 2024
228e836
entirely remove unnecessary force RN version
TMisiukiewicz Oct 4, 2024
4155ee3
remove unnecessary node_modules_dir set
TMisiukiewicz Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,6 @@ allprojects {
configurations.all {
resolutionStrategy {
force 'org.xerial:sqlite-jdbc:3.34.0'

// Manually set the react-native version to resolve this upstream issue: https://github.com/facebook/react-native/issues/35210
def REACT_NATIVE_VERSION = new File(['node', '--print',"JSON.parse(require('fs').readFileSync(require.resolve('react-native/package.json'), 'utf-8')).version"].execute(null, rootDir).text.trim())
force "com.facebook.react:react-native:" + REACT_NATIVE_VERSION
force "com.facebook.react:hermes-engine:" + REACT_NATIVE_VERSION

//Fix Investigate App Crash MainActivity.onCreate #35655
force "com.facebook.soloader:soloader:0.10.4+"

Expand Down
Loading