-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Add GoogleTagManger libs #51201
Conversation
This firebase upgrade requires use_frameworks which seems to not be compatible with some of our packages and the new fabric architecture.
I'm going to try to move forward without a firebase upgrade and see if it still works in the DebugView. |
I'm having Android build issues, but I can successfully build iOS without I managed to fix the plaid error by defining the |
de0db37
to
92c5442
Compare
Alright I've split this into two PR's. This one just adds the GTM library with no firebase upgrade. #51413 does both. Good news is I got the DebugView to work on iOS!
|
Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work? |
Alright this is code complete and testing well. We'll move forward without upgrading Firebase for now. |
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-11-01.at.3.39.49.AM.movAndroid: mWeb ChromeScreen.Recording.2024-11-01.at.3.38.23.AM.moviOS: NativeScreen.Recording.2024-11-01.at.3.36.14.AM.moviOS: mWeb SafariScreen.Recording.2024-11-01.at.3.32.47.AM.movMacOS: Chrome / SafariScreen.Recording.2024-11-01.at.3.27.59.AM.movMacOS: DesktopScreen.Recording.2024-11-01.at.3.30.29.AM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works good!
@neil-marcellini Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thank you. I left some NABs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.57-0 🚀
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.57-10 🚀
|
Details
Adds GoogleTagManager libs that we'll start using to publish analytics events. The web lib uses a third party google script we embed in the app and the native lib uses
react-native-firebase
to publish the same events.Fixed Issues
$ #50938
Tests
Note: No mWeb tests since we need to view console/logs
GTM lib
USE_THIRD_PARTY_SCRIPTS=true
to your .envios/GoogleService-Info.plist
android/app/google-services.json
[GTM] event published
logProduction build
npm run build
dist/index.html
contains<script async="" src="thirdPartyScripts.js">
Offline tests
None
QA Steps
None
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
iOS: Native
MacOS: Chrome / Safari
MacOS: Desktop